chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm - Issue 1182183003: Move EndsWith to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm

Issue 1182183003: Move EndsWith to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm

index 9cef5fa94b8881782b13833c328a813140648e63..053002fdbc5cef734df541dbc0b3534766aa162b 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm

@@ -527,7 +527,7 @@ NSAttributedString* CreateClassifiedAttributedString(

&contentsStartIndex);

// Ignore invalid state.

if (!base::StartsWith(match.fill_into_edit, inputText, true) ||

- !EndsWith(match.fill_into_edit, match.contents, true) ||

+ !base::EndsWith(match.fill_into_edit, match.contents, true) ||

((size_t)contentsStartIndex >= inputText.length())) {

return 0;

}