Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: tools/gn/ninja_binary_target_writer.cc

Issue 1182183003: Move EndsWith to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/zlib/google/zip_reader.cc ('k') | tools/gn/ninja_target_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_binary_target_writer.cc
diff --git a/tools/gn/ninja_binary_target_writer.cc b/tools/gn/ninja_binary_target_writer.cc
index 7a611dbdd015303ae21485dbf68f8218aeccc0cf..680c0d9db459ac6366cfaef01448e0d2d106c992 100644
--- a/tools/gn/ninja_binary_target_writer.cc
+++ b/tools/gn/ninja_binary_target_writer.cc
@@ -336,7 +336,8 @@ void NinjaBinaryTargetWriter::WriteLibs() {
const OrderedSet<std::string> all_libs = target_->all_libs();
const std::string framework_ending(".framework");
for (size_t i = 0; i < all_libs.size(); i++) {
- if (settings_->IsMac() && EndsWith(all_libs[i], framework_ending, false)) {
+ if (settings_->IsMac() &&
+ base::EndsWith(all_libs[i], framework_ending, false)) {
// Special-case libraries ending in ".framework" on Mac. Add the
// -framework switch and don't add the extension to the output.
out_ << " -framework ";
« no previous file with comments | « third_party/zlib/google/zip_reader.cc ('k') | tools/gn/ninja_target_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698