chrome/browser/extensions/updater/local_extension_cache.cc - Issue 1182183003: Move EndsWith to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/updater/local_extension_cache.cc

Issue 1182183003: Move EndsWith to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/updater/local_extension_cache.cc

diff --git a/chrome/browser/extensions/updater/local_extension_cache.cc b/chrome/browser/extensions/updater/local_extension_cache.cc

index 74dec3998e86b6fff13740d6c900777e8c025118..677b3e87d0f338578de8a6387881a6ad71fd84fb 100644

--- a/chrome/browser/extensions/updater/local_extension_cache.cc

+++ b/chrome/browser/extensions/updater/local_extension_cache.cc

@@ -420,7 +420,8 @@ void LocalExtensionCache::BackendCheckCacheContentsInternal(

std::string id;

std::string version;

std::string expected_hash;

- if (EndsWith(basename, kCRXFileExtension, false /* case-sensitive */)) {

+ if (base::EndsWith(basename, kCRXFileExtension,

+ false /* case-sensitive */)) {

size_t n = basename.find('-');

if (n != std::string::npos && n + 1 < basename.size() - 4) {

id = basename.substr(0, n);