Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1181333005: Convert some ChromeVox functional getters to properties. (Closed)

Created:
5 years, 6 months ago by David Tseng
Modified:
5 years, 4 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@traversal_root
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert some ChromeVox functional getters to properties. Committed: https://crrev.com/84ddb07776155ce3ce5ee83a6839dea9525e01ba Cr-Commit-Position: refs/heads/master@{#341222}

Patch Set 1 #

Patch Set 2 : Rebase onto master. #

Patch Set 3 : Rebase. #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -38 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 1 2 9 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js View 6 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 2 3 4 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
David Tseng
5 years, 6 months ago (2015-06-17 19:24:34 UTC) #2
David Tseng
+ plundblad. Tired of typing more than I need to into the console :).
5 years, 4 months ago (2015-07-29 22:48:27 UTC) #4
Peter Lundblad
lgtm This improves the code readability as well, in addition to making life nicer in ...
5 years, 4 months ago (2015-07-30 09:19:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181333005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1181333005/40001
5 years, 4 months ago (2015-07-30 15:14:51 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/51069) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 4 months ago (2015-07-30 15:16:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181333005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1181333005/60001
5 years, 4 months ago (2015-07-30 22:56:24 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 4 months ago (2015-07-30 23:28:02 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 23:28:38 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/84ddb07776155ce3ce5ee83a6839dea9525e01ba
Cr-Commit-Position: refs/heads/master@{#341222}

Powered by Google App Engine
This is Rietveld 408576698