Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2904)

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

Issue 1181333005: Convert some ChromeVox functional getters to properties. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@traversal_root
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
index d928cd225dee66cb6b4dd9af41a176b65595705d..d93ab5fef784679a6c4bffe816d8159d188b8d21 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
@@ -257,7 +257,7 @@ Background.prototype = {
break;
case 'goToBeginning':
var node =
- AutomationUtil.findNodePost(current.getStart().getNode().root,
+ AutomationUtil.findNodePost(current.start.node.root,
Dir.FORWARD,
AutomationPredicate.leaf);
if (node)
@@ -265,7 +265,7 @@ Background.prototype = {
break;
case 'goToEnd':
var node =
- AutomationUtil.findNodePost(current.getStart().getNode().root,
+ AutomationUtil.findNodePost(current.start.node.root,
Dir.BACKWARD,
AutomationPredicate.leaf);
if (node)
@@ -273,7 +273,7 @@ Background.prototype = {
break;
case 'doDefault':
if (this.currentRange_) {
- var actionNode = this.currentRange_.getStart().getNode();
+ var actionNode = this.currentRange_.start.node;
if (actionNode.role == chrome.automation.RoleType.inlineTextBox)
actionNode = actionNode.parent;
actionNode.doDefault();
@@ -303,7 +303,7 @@ Background.prototype = {
return;
case 'showContextMenu':
if (this.currentRange_) {
- var actionNode = this.currentRange_.getStart().getNode();
+ var actionNode = this.currentRange_.start.node;
if (actionNode.role == chrome.automation.RoleType.inlineTextBox)
actionNode = actionNode.parent;
actionNode.showContextMenu();
@@ -318,7 +318,7 @@ Background.prototype = {
if (pred) {
var node = AutomationUtil.findNextNode(
- current.getBound(dir).getNode(), dir, pred);
+ current.getBound(dir).node, dir, pred);
if (node) {
current = cursors.Range.fromNode(node);
@@ -333,7 +333,7 @@ Background.prototype = {
if (current) {
// TODO(dtseng): Figure out what it means to focus a range.
- var actionNode = current.getStart().getNode();
+ var actionNode = current.start.node;
if (actionNode.role == chrome.automation.RoleType.inlineTextBox)
actionNode = actionNode.parent;
actionNode.focus();
@@ -399,7 +399,7 @@ Background.prototype = {
// are not within web content.
if (node.root.role == 'desktop' ||
!prevRange ||
- (prevRange.getStart().getNode().root != node.root &&
+ (prevRange.start.node.root != node.root &&
node.state.focused))
this.setupChromeVoxVariants_(node.root.docUrl || '');
@@ -503,7 +503,7 @@ Background.prototype = {
evt.target.textSelEnd,
true); // triggered by user
if (!this.editableTextHandler ||
- evt.target != this.currentRange_.getStart().getNode()) {
+ evt.target != this.currentRange_.start.node) {
this.editableTextHandler =
new cvox.ChromeVoxEditableTextBase(
textChangeEvent.value,
@@ -656,7 +656,7 @@ Background.prototype = {
} else {
// When in compat mode, if the focus is within the desktop tree proper,
// then do not disable content scripts.
- if (this.currentRange_.getStart().getNode().root.role == 'desktop')
+ if (this.currentRange_.start.node.root.role == 'desktop')
return;
this.disableClassicChromeVox_();
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698