chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs - Issue 1181333005: Convert some ChromeVox functional getters to properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs

Issue 1181333005: Convert some ChromeVox functional getters to properties. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@traversal_root

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs b/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs

index 6a0affb6023a56a0a9bb03cd36721db06b5cd6d7..090e757e721a8e7a80abc387182aa1170b0a846e 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs

@@ -73,8 +73,8 @@ CursorsTest.prototype = {

var expectedStart = move[2];

var expectedEnd = move[3];

- this.makeCursorAssertion(expectedStart, range.getStart());

- this.makeCursorAssertion(expectedEnd, range.getEnd());

+ this.makeCursorAssertion(expectedStart, range.start);

+ this.makeCursorAssertion(expectedEnd, range.end);

}

@@ -87,7 +87,7 @@ CursorsTest.prototype = {

if (goog.isDef(expected.index))

assertEquals(expected.index, cursor.getIndex());

if (goog.isDef(expected.value))

- assertEquals(expected.value, cursor.getNode().value);

+ assertEquals(expected.value, cursor.node.value);

/**