Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

Issue 1181333005: Convert some ChromeVox functional getters to properties. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@traversal_root
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
index 08b5d92da09e8656d832e2ed5db43f18ecc55487..f1dc9d5fc923182eae1e7fc028a7feb540bc4b8a 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
@@ -989,10 +989,10 @@ Output.prototype = {
*/
range_: function(range, prevRange, type, rangeBuff) {
if (!prevRange)
- prevRange = cursors.Range.fromNode(range.getStart().getNode().root);
+ prevRange = cursors.Range.fromNode(range.start.node.root);
- var cursor = range.getStart();
- var prevNode = prevRange.getStart().getNode();
+ var cursor = range.start;
+ var prevNode = prevRange.start.node;
var formatNodeAndAncestors = function(node, prevNode) {
var buff = [];
@@ -1003,8 +1003,8 @@ Output.prototype = {
return buff;
}.bind(this);
- while (cursor.getNode() != range.getEnd().getNode()) {
- var node = cursor.getNode();
+ while (cursor.node != range.end.node) {
+ var node = cursor.node;
rangeBuff.push.apply(rangeBuff, formatNodeAndAncestors(node, prevNode));
prevNode = node;
cursor = cursor.move(cursors.Unit.NODE,
@@ -1012,10 +1012,10 @@ Output.prototype = {
Dir.FORWARD);
// Reached a boundary.
- if (cursor.getNode() == prevNode)
+ if (cursor.node == prevNode)
break;
}
- var lastNode = range.getEnd().getNode();
+ var lastNode = range.end.node;
rangeBuff.push.apply(rangeBuff, formatNodeAndAncestors(lastNode, prevNode));
},
@@ -1117,16 +1117,16 @@ Output.prototype = {
if (!prevRange)
prevRange = range;
var dir = cursors.Range.getDirection(prevRange, range);
- var prevNode = prevRange.getBound(dir).getNode();
+ var prevNode = prevRange.getBound(dir).node;
this.ancestry_(
- range.getStart().getNode(), prevNode, type, buff,
+ range.start.node, prevNode, type, buff,
{stay: true, name: true, value: true});
- var startIndex = range.getStart().getIndex();
- var endIndex = range.getEnd().getIndex();
+ var startIndex = range.start.getIndex();
+ var endIndex = range.end.getIndex();
if (startIndex === endIndex)
endIndex++;
this.append_(
- buff, range.getStart().getText().substring(startIndex, endIndex));
+ buff, range.start.getText().substring(startIndex, endIndex));
},
/**
« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698