Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 1180553002: Ink splashes should start at the touch point (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Ink splashes should start at the touch point Previously, they always started at the center of the RenderInkWell. Now we remember the local coordinates we computed during the hit test and provide that information when handling the event. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/732436709b82abc63157f0ec900f139b1b258dd1

Patch Set 1 #

Patch Set 2 : Use more specific types for GameBox and SpriteBox #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -19 lines) Patch
M sky/examples/game/lib/game_box.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/game/lib/sprite_box.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/raw/sector_layout.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M sky/examples/raw/touch_demo.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/app.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components2/ink_well.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/fn2.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/rendering/box.dart View 3 chunks +9 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/rendering/object.dart View 2 chunks +11 lines, -5 lines 4 comments Download
M sky/tests/raw/render_flex.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-06-10 20:43:21 UTC) #1
Hixie
lgtm https://codereview.chromium.org/1180553002/diff/20001/sky/sdk/lib/framework/rendering/object.dart File sky/sdk/lib/framework/rendering/object.dart (right): https://codereview.chromium.org/1180553002/diff/20001/sky/sdk/lib/framework/rendering/object.dart#newcode256 sky/sdk/lib/framework/rendering/object.dart:256: class HitTestData { HitTestEntry and rename all the ...
5 years, 6 months ago (2015-06-10 20:51:49 UTC) #2
abarth-chromium
5 years, 6 months ago (2015-06-10 20:55:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
732436709b82abc63157f0ec900f139b1b258dd1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698