Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: sky/sdk/lib/framework/rendering/object.dart

Issue 1180553002: Ink splashes should start at the touch point (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Use more specific types for GameBox and SpriteBox Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/lib/framework/rendering/box.dart ('k') | sky/tests/raw/render_flex.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/framework/rendering/object.dart
diff --git a/sky/sdk/lib/framework/rendering/object.dart b/sky/sdk/lib/framework/rendering/object.dart
index e6f8ba72814da5726e8fff04dd6e7190e94ad1ff..f08dff4b6a28f7a54303980a236a1f8f8503965f 100644
--- a/sky/sdk/lib/framework/rendering/object.dart
+++ b/sky/sdk/lib/framework/rendering/object.dart
@@ -204,7 +204,7 @@ abstract class RenderObject extends AbstractNode {
// EVENTS
- void handleEvent(sky.Event event) {
+ void handleEvent(sky.Event event, HitTestData data) {
// override this if you have a client, to hand it to the client
// override this if you want to do anything with the event
}
@@ -253,13 +253,19 @@ abstract class RenderObject extends AbstractNode {
}
+class HitTestData {
Hixie 2015/06/10 20:51:49 HitTestEntry and rename all the variables that re
+ final RenderObject entry;
Hixie 2015/06/10 20:51:49 Rename this to "target".
+
+ HitTestData(this.entry);
+}
Hixie 2015/06/10 20:51:49 Constructor first, then fields. Also, make the con
+
class HitTestResult {
- final List<RenderObject> path = new List<RenderObject>();
+ final List<HitTestData> path = new List<HitTestData>();
- RenderObject get result => path.first;
+ RenderObject get result => path.first.entry;
Hixie 2015/06/10 20:51:49 If we don't use this, drop it. If we do, maybe ren
- void add(RenderObject node) {
- path.add(node);
+ void add(HitTestData data) {
+ path.add(data);
}
}
« no previous file with comments | « sky/sdk/lib/framework/rendering/box.dart ('k') | sky/tests/raw/render_flex.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698