Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1695)

Unified Diff: sky/sdk/lib/framework/rendering/box.dart

Issue 1180553002: Ink splashes should start at the touch point (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Use more specific types for GameBox and SpriteBox Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/sdk/lib/framework/rendering/box.dart
diff --git a/sky/sdk/lib/framework/rendering/box.dart b/sky/sdk/lib/framework/rendering/box.dart
index ddbd78e63c41f7a5e9153a53d83fe5d6b5ef3c8e..8eda5c04111bda6d0338d7b3daa20aa62eed9e0e 100644
--- a/sky/sdk/lib/framework/rendering/box.dart
+++ b/sky/sdk/lib/framework/rendering/box.dart
@@ -165,6 +165,13 @@ class BoxConstraints {
String toString() => "BoxConstraints($minWidth<=w<$maxWidth, $minHeight<=h<$maxHeight)";
}
+class BoxHitTestData extends HitTestData {
+ final Point localPosition;
+
+ BoxHitTestData(RenderBox entry, this.localPosition)
+ : super(entry);
+}
+
class BoxParentData extends ParentData {
Point _position = Point.origin;
Point get position => _position;
@@ -225,7 +232,7 @@ abstract class RenderBox extends RenderObject {
bool hitTest(HitTestResult result, { Point position }) {
hitTestChildren(result, position: position);
- result.add(this);
+ result.add(new BoxHitTestData(this, position));
return true;
}
void hitTestChildren(HitTestResult result, { Point position }) { }
@@ -1073,7 +1080,7 @@ class RenderView extends RenderObject with RenderObjectWithChildMixin<RenderBox>
if (childBounds.contains(position))
child.hitTest(result, position: position);
}
- result.add(this);
+ result.add(new HitTestData(this));
return true;
}

Powered by Google App Engine
This is Rietveld 408576698