Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2290)

Unified Diff: sky/sdk/lib/framework/components2/ink_well.dart

Issue 1180553002: Ink splashes should start at the touch point (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Use more specific types for GameBox and SpriteBox Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/sdk/lib/framework/components2/ink_well.dart
diff --git a/sky/sdk/lib/framework/components2/ink_well.dart b/sky/sdk/lib/framework/components2/ink_well.dart
index c793e3e24c71a995ef7a8a5d0bbb4cc01159555a..bfb18190120e25a57d642329d2a499393703d116 100644
--- a/sky/sdk/lib/framework/components2/ink_well.dart
+++ b/sky/sdk/lib/framework/components2/ink_well.dart
@@ -66,11 +66,11 @@ class RenderInkWell extends RenderProxyBox {
final List<InkSplash> _splashes = new List<InkSplash>();
- void handleEvent(sky.Event event) {
+ void handleEvent(sky.Event event, BoxHitTestData data) {
switch (event.type) {
case 'gesturetapdown':
// TODO(abarth): We should position the splash at the location of the tap.
- _startSplash(event.primaryPointer, new Point(size.width / 2.0, size.height / 2.0));
+ _startSplash(event.primaryPointer, data.localPosition);
break;
case 'gesturetap':
_confirmSplash(event.primaryPointer);

Powered by Google App Engine
This is Rietveld 408576698