Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 1179333002: Playable demo game and bug fixes in sprites (Closed)

Created:
5 years, 6 months ago by viktorl
Modified:
5 years, 6 months ago
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Updates game for new AppView API Deletes old test game Demo game is now playable Updates demo game with steering and changes in sprites Fixes smaller bugs in sprites Refactor class names in game demo Strips Box2D from game Fixes ordering in game node Adds frameRate property to SpriteBox and improves update methods. Fixes node to box transformations for hit tests Fixes minor code issues R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1706642759307ce6bb62d648222b1e44f334e5e0

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+401 lines, -450 lines) Patch
D sky/examples/game/lib/game.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D sky/examples/game/lib/game_box.dart View 1 chunk +0 lines, -71 lines 0 comments Download
A sky/examples/game/lib/game_demo.dart View 1 chunk +10 lines, -0 lines 0 comments Download
A + sky/examples/game/lib/game_demo_box.dart View 4 chunks +25 lines, -16 lines 0 comments Download
A sky/examples/game/lib/game_demo_world.dart View 1 chunk +285 lines, -0 lines 2 comments Download
D sky/examples/game/lib/game_tests.dart View 1 chunk +0 lines, -131 lines 0 comments Download
D sky/examples/game/lib/game_world.dart View 1 chunk +0 lines, -191 lines 0 comments Download
M sky/examples/game/lib/node.dart View 8 chunks +23 lines, -12 lines 1 comment Download
M sky/examples/game/lib/node_with_size.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/examples/game/lib/sprite.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/examples/game/lib/sprite_box.dart View 6 chunks +48 lines, -6 lines 0 comments Download
M sky/examples/game/lib/sprites.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/game/main.dart View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
viktorl
5 years, 6 months ago (2015-06-12 23:33:13 UTC) #2
abarth-chromium
lgtm https://codereview.chromium.org/1179333002/diff/1/sky/examples/game/lib/game_demo_world.dart File sky/examples/game/lib/game_demo_world.dart (right): https://codereview.chromium.org/1179333002/diff/1/sky/examples/game/lib/game_demo_world.dart#newcode259 sky/examples/game/lib/game_demo_world.dart:259: } We have an operator+ for Point and ...
5 years, 6 months ago (2015-06-13 00:03:21 UTC) #4
viktorl
5 years, 6 months ago (2015-06-15 16:11:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1706642759307ce6bb62d648222b1e44f334e5e0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698