Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1178723007: disable floating point textures if GLSL version is < 330 (Closed)

Created:
5 years, 6 months ago by joshua.litt
Modified:
5 years, 6 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

disable floating point textures if GLSL version is < 330 BUG=skia: Committed: https://skia.googlesource.com/skia/+/5599996b720134a04897b0841b50e88872d5d6af

Patch Set 1 #

Patch Set 2 : tweak #

Total comments: 1

Patch Set 3 : tweaks #

Patch Set 4 : tweaks #

Total comments: 1

Patch Set 5 : tweak #

Patch Set 6 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M src/gpu/gl/GrGLCaps.cpp View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLContext.cpp View 1 2 3 4 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
joshualitt
ptal
5 years, 6 months ago (2015-06-17 19:21:43 UTC) #2
bsalomon
https://codereview.chromium.org/1178723007/diff/20001/src/gpu/gl/GrGLCaps.cpp File src/gpu/gl/GrGLCaps.cpp (right): https://codereview.chromium.org/1178723007/diff/20001/src/gpu/gl/GrGLCaps.cpp#newcode546 src/gpu/gl/GrGLCaps.cpp:546: ctxInfo.glslGeneration() >= k330_GrGLSLGeneration) { need this for desktop too?
5 years, 6 months ago (2015-06-17 20:10:46 UTC) #3
joshualitt
On 2015/06/17 20:10:46, bsalomon wrote: > https://codereview.chromium.org/1178723007/diff/20001/src/gpu/gl/GrGLCaps.cpp > File src/gpu/gl/GrGLCaps.cpp (right): > > https://codereview.chromium.org/1178723007/diff/20001/src/gpu/gl/GrGLCaps.cpp#newcode546 > ...
5 years, 6 months ago (2015-06-18 16:16:29 UTC) #4
bsalomon
lgtm if you fix the !kAdreno == renderer thing.
5 years, 6 months ago (2015-06-18 17:14:57 UTC) #5
joshualitt
ptal
5 years, 6 months ago (2015-06-18 17:47:47 UTC) #6
bsalomon
https://codereview.chromium.org/1178723007/diff/60001/src/gpu/gl/GrGLContext.cpp File src/gpu/gl/GrGLContext.cpp (right): https://codereview.chromium.org/1178723007/diff/60001/src/gpu/gl/GrGLContext.cpp#newcode51 src/gpu/gl/GrGLContext.cpp:51: * 06/18/2015 - This bug does not effect the ...
5 years, 6 months ago (2015-06-18 17:49:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178723007/100001
5 years, 6 months ago (2015-06-18 20:37:45 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 20:47:14 UTC) #12
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/5599996b720134a04897b0841b50e88872d5d6af

Powered by Google App Engine
This is Rietveld 408576698