Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: src/gpu/gl/GrGLContext.cpp

Issue 1178723007: disable floating point textures if GLSL version is < 330 (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: more Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/gpu/gl/GrGLCaps.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/gl/GrGLContext.cpp
diff --git a/src/gpu/gl/GrGLContext.cpp b/src/gpu/gl/GrGLContext.cpp
index 6f23eca847c6f7503bec4872e5fb7ef293b08389..adbc5d9e866b0affb74a2fd673dd9af8d2f1d344 100644
--- a/src/gpu/gl/GrGLContext.cpp
+++ b/src/gpu/gl/GrGLContext.cpp
@@ -40,18 +40,20 @@ GrGLContext* GrGLContext::Create(const GrGLInterface* interface, const GrContext
args.fVendor = GrGLGetVendor(interface);
+ args.fRenderer = GrGLGetRendererFromString(renderer);
+
/*
- * Qualcomm drivers have a horrendous bug with some drivers. Though they claim to
- * support GLES 3.00, some perfectly valid GLSL300 shaders will only compile with
+ * Qualcomm drivers for the 3xx series have a horrendous bug with some drivers. Though they
+ * claim to support GLES 3.00, some perfectly valid GLSL300 shaders will only compile with
* #version 100, and will fail to compile with #version 300 es. In the long term, we
* need to lock this down to a specific driver version.
+ * ?????/2015 - This bug is still present in Lollipop pre-mr1
+ * 06/18/2015 - This bug does not affect the nexus 6 (which has an Adreno 4xx).
*/
- if (kQualcomm_GrGLVendor == args.fVendor) {
+ if (kAdreno3xx_GrGLRenderer == args.fRenderer) {
args.fGLSLGeneration = k110_GrGLSLGeneration;
}
- args.fRenderer = GrGLGetRendererFromString(renderer);
-
GrGLGetDriverInfo(interface->fStandard, args.fVendor, renderer, ver,
&args.fDriver, &args.fDriverVersion);
« no previous file with comments | « src/gpu/gl/GrGLCaps.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698