Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: src/gpu/gl/GrGLCaps.cpp

Issue 1178723007: disable floating point textures if GLSL version is < 330 (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: more Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/gpu/gl/GrGLContext.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 Google Inc. 2 * Copyright 2012 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 8
9 #include "GrGLCaps.h" 9 #include "GrGLCaps.h"
10 10
(...skipping 524 matching lines...) Expand 10 before | Expand all | Expand 10 after
535 fConfigRenderSupport[kSRGBA_8888_GrPixelConfig][kYes_MSAA] = tru e; 535 fConfigRenderSupport[kSRGBA_8888_GrPixelConfig][kYes_MSAA] = tru e;
536 } 536 }
537 } 537 }
538 } 538 }
539 539
540 if (this->isConfigTexturable(kRGBA_float_GrPixelConfig)) { 540 if (this->isConfigTexturable(kRGBA_float_GrPixelConfig)) {
541 if (kGL_GrGLStandard == standard) { 541 if (kGL_GrGLStandard == standard) {
542 fConfigRenderSupport[kRGBA_float_GrPixelConfig][kNo_MSAA] = true; 542 fConfigRenderSupport[kRGBA_float_GrPixelConfig][kNo_MSAA] = true;
543 fConfigRenderSupport[kRGBA_float_GrPixelConfig][kYes_MSAA] = true; 543 fConfigRenderSupport[kRGBA_float_GrPixelConfig][kYes_MSAA] = true;
544 } else { 544 } else {
545 // for now we only enable this on desktop, because on ES we'd have t o solve many
546 // precision issues and no clients actually want this yet
547 /*
545 if (ctxInfo.hasExtension("GL_EXT_color_buffer_float")) { 548 if (ctxInfo.hasExtension("GL_EXT_color_buffer_float")) {
546 fConfigRenderSupport[kRGBA_float_GrPixelConfig][kNo_MSAA] = true ; 549 fConfigRenderSupport[kRGBA_float_GrPixelConfig][kNo_MSAA] = true ;
547 } else { 550 } else {
548 fConfigRenderSupport[kRGBA_float_GrPixelConfig][kNo_MSAA] = fals e; 551 fConfigRenderSupport[kRGBA_float_GrPixelConfig][kNo_MSAA] = fals e;
549 } 552 }
550 // for now we don't support floating point MSAA on ES 553 // for now we don't support floating point MSAA on ES
554 fConfigRenderSupport[kRGBA_float_GrPixelConfig][kYes_MSAA] = false;* /
555 fConfigRenderSupport[kRGBA_float_GrPixelConfig][kNo_MSAA] = false;
551 fConfigRenderSupport[kRGBA_float_GrPixelConfig][kYes_MSAA] = false; 556 fConfigRenderSupport[kRGBA_float_GrPixelConfig][kYes_MSAA] = false;
552 } 557 }
553 } 558 }
554 559
555 if (this->isConfigTexturable(kAlpha_half_GrPixelConfig)) { 560 if (this->isConfigTexturable(kAlpha_half_GrPixelConfig)) {
556 if (kGL_GrGLStandard == standard) { 561 if (kGL_GrGLStandard == standard) {
557 fConfigRenderSupport[kAlpha_half_GrPixelConfig][kNo_MSAA] = true; 562 fConfigRenderSupport[kAlpha_half_GrPixelConfig][kNo_MSAA] = true;
558 fConfigRenderSupport[kAlpha_half_GrPixelConfig][kYes_MSAA] = true; 563 fConfigRenderSupport[kAlpha_half_GrPixelConfig][kYes_MSAA] = true;
559 } else if (ctxInfo.version() >= GR_GL_VER(3,0)) { 564 } else if (ctxInfo.version() >= GR_GL_VER(3,0)) {
560 fConfigRenderSupport[kAlpha_half_GrPixelConfig][kNo_MSAA] = true; 565 fConfigRenderSupport[kAlpha_half_GrPixelConfig][kNo_MSAA] = true;
(...skipping 615 matching lines...) Expand 10 before | Expand all | Expand 10 after
1176 if (fGeometryShaderSupport) { 1181 if (fGeometryShaderSupport) {
1177 for (int p = 0; p < kGrSLPrecisionCount; ++p) { 1182 for (int p = 0; p < kGrSLPrecisionCount; ++p) {
1178 fFloatPrecisions[kGeometry_GrShaderType][p] = fFloatPrecisions[kVert ex_GrShaderType][p]; 1183 fFloatPrecisions[kGeometry_GrShaderType][p] = fFloatPrecisions[kVert ex_GrShaderType][p];
1179 } 1184 }
1180 } 1185 }
1181 } 1186 }
1182 1187
1183 1188
1184 1189
1185 1190
OLDNEW
« no previous file with comments | « no previous file | src/gpu/gl/GrGLContext.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698