fixes #215, removes special case for length

fixes #215, removes special case for length

R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/03b60dbff789e80a746582e6b169488c7699fcde

[Jennifer Messerly, 2015-06-10 16:50:36]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[Jennifer Messerly, 2015-06-10 16:50:36]

Although code reads better before, the inconsistency causes problems.
Alternative would be to handle this in dynamic invokes, but now the special case
proliferates.

The ultimate solution here is probably what we need for dart:html, ability to
mix extensions and native props. Then we can have "length" be exposing the
native prop, if we want that. But we don't have that mechanism in place yet, so
safer to remove for now.

[vsm, 2015-06-10 17:00:47]

https://codereview.chromium.org/1178523004/diff/1/lib/src/codegen/js_codegen....
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1178523004/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:2673: return js.call('dartx.#',
_propertyName(name));
Will this really fix the broken text example?

There, I'm seeing this:

core.print(dart.dload(exports.l, 'length'));

[Jennifer Messerly, 2015-06-10 17:13:16]

https://codereview.chromium.org/1178523004/diff/1/lib/src/codegen/js_codegen....
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1178523004/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:2673: return js.call('dartx.#',
_propertyName(name));
On 2015/06/10 17:00:46, vsm wrote:
> Will this really fix the broken text example?
> 
> There, I'm seeing this:
> 
> core.print(dart.dload(exports.l, 'length'));

yup. It works because of this logic:
https://github.com/dart-lang/dev_compiler/blob/master/lib/runtime/dart_runtim...

for dynamic dispatch to a Dart type or a Dart "extension type", we hide all JS
methods, that's why it's not finding "length", but it will find [dartx.length]

[vsm, 2015-06-10 17:37:51]

thanks!

lgtm

[Jennifer Messerly, 2015-06-10 19:21:52]

Committed patchset #1 (id:1) manually as
03b60dbff789e80a746582e6b169488c7699fcde (presubmit successful).