Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: lib/src/codegen/js_codegen.dart

Issue 1178523004: fixes #215, removes special case for length (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/runtime/dart/isolate.js ('k') | test/codegen/expect/BenchmarkBase.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/codegen/js_codegen.dart
diff --git a/lib/src/codegen/js_codegen.dart b/lib/src/codegen/js_codegen.dart
index 62a5a01109d3206ec36ea4a3325e510a5eeeb64c..d82e26a75f8fdab8e90e8b4c0b2f0cadc6d170e2 100644
--- a/lib/src/codegen/js_codegen.dart
+++ b/lib/src/codegen/js_codegen.dart
@@ -2670,8 +2670,7 @@ class JSCodegenVisitor extends GeneralizingAstVisitor {
// Dart "extension" methods. Used for JS Array, Boolean, Number, String.
if (allowExtensions && _extensionTypes.contains(type.element)) {
- // Special case `length`. We can call it directly.
- if (name != 'length') return js.call('dartx.#', _propertyName(name));
+ return js.call('dartx.#', _propertyName(name));
vsm 2015/06/10 17:00:46 Will this really fix the broken text example? The
Jennifer Messerly 2015/06/10 17:13:16 yup. It works because of this logic: https://githu
}
return _propertyName(name);
« no previous file with comments | « lib/runtime/dart/isolate.js ('k') | test/codegen/expect/BenchmarkBase.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698