Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Unified Diff: lib/runtime/dart/_native_typed_data.js

Issue 1178523004: fixes #215, removes special case for length (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/runtime/dart/_native_typed_data.js
diff --git a/lib/runtime/dart/_native_typed_data.js b/lib/runtime/dart/_native_typed_data.js
index 5892f584020595e9eff964de5d7f976b65e35f7a..ff48c40301976882d161770897f44155aca8003a 100644
--- a/lib/runtime/dart/_native_typed_data.js
+++ b/lib/runtime/dart/_native_typed_data.js
@@ -158,8 +158,8 @@ dart.library('dart/_native_typed_data', null, /* Imports */[
this[_storage] = storage;
}
_slowFromList(list) {
- this[_storage] = NativeFloat32List.new(dart.notNull(list.length) * 4);
- for (let i = 0; dart.notNull(i) < dart.notNull(list.length); i = dart.notNull(i) + 1) {
+ this[_storage] = NativeFloat32List.new(dart.notNull(list[dartx.length]) * 4);
+ for (let i = 0; dart.notNull(i) < dart.notNull(list[dartx.length]); i = dart.notNull(i) + 1) {
let e = list[dartx.get](i);
this[_storage].set(dart.notNull(i) * 4 + 0, e.x);
this[_storage].set(dart.notNull(i) * 4 + 1, e.y);
@@ -266,8 +266,8 @@ dart.library('dart/_native_typed_data', null, /* Imports */[
this[_storage] = storage;
}
_slowFromList(list) {
- this[_storage] = NativeInt32List.new(dart.notNull(list.length) * 4);
- for (let i = 0; dart.notNull(i) < dart.notNull(list.length); i = dart.notNull(i) + 1) {
+ this[_storage] = NativeInt32List.new(dart.notNull(list[dartx.length]) * 4);
+ for (let i = 0; dart.notNull(i) < dart.notNull(list[dartx.length]); i = dart.notNull(i) + 1) {
let e = list[dartx.get](i);
this[_storage].set(dart.notNull(i) * 4 + 0, e.x);
this[_storage].set(dart.notNull(i) * 4 + 1, e.y);
@@ -374,8 +374,8 @@ dart.library('dart/_native_typed_data', null, /* Imports */[
this[_storage] = storage;
}
_slowFromList(list) {
- this[_storage] = NativeFloat64List.new(dart.notNull(list.length) * 2);
- for (let i = 0; dart.notNull(i) < dart.notNull(list.length); i = dart.notNull(i) + 1) {
+ this[_storage] = NativeFloat64List.new(dart.notNull(list[dartx.length]) * 2);
+ for (let i = 0; dart.notNull(i) < dart.notNull(list[dartx.length]); i = dart.notNull(i) + 1) {
let e = list[dartx.get](i);
this[_storage].set(dart.notNull(i) * 2 + 0, e.x);
this[_storage].set(dart.notNull(i) * 2 + 1, e.y);
@@ -533,8 +533,8 @@ dart.library('dart/_native_typed_data', null, /* Imports */[
function _ensureNativeList(list) {
if (dart.is(list, _interceptors.JSIndexable))
return list;
- let result = core.List.new(list.length);
- for (let i = 0; dart.notNull(i) < dart.notNull(list.length); i = dart.notNull(i) + 1) {
+ let result = core.List.new(list[dartx.length]);
+ for (let i = 0; dart.notNull(i) < dart.notNull(list[dartx.length]); i = dart.notNull(i) + 1) {
result[dartx.set](i, list[dartx.get](i));
}
return result;

Powered by Google App Engine
This is Rietveld 408576698