lib/runtime/dart/isolate.js - Issue 1178523004: fixes #215, removes special case for length

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/runtime/dart/isolate.js

Issue 1178523004: fixes #215, removes special case for length (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/runtime/dart/isolate.js

diff --git a/lib/runtime/dart/isolate.js b/lib/runtime/dart/isolate.js

index dc371ad98979a7902c5eae1b56a57a21e368dd33..e6ba40285cda72d4a80e290d0d2bb456d5cf09bc 100644

--- a/lib/runtime/dart/isolate.js

+++ b/lib/runtime/dart/isolate.js

@@ -54,7 +54,7 @@ dart.library('dart/isolate', null, /* Imports */[

throw new core.UnimplementedError("packageRoot");

try {

if (dart.is(args, core.List)) {

- for (let i = 0; dart.notNull(i) < dart.notNull(args.length); i = dart.notNull(i) + 1) {

+ for (let i = 0; dart.notNull(i) < dart.notNull(args[dartx.length]); i = dart.notNull(i) + 1) {

if (!(typeof args[dartx.get](i) == 'string')) {

throw new core.ArgumentError(`Args must be a list of Strings ${args}`);

}