Be more consistent about respecting link click dispositions in infobars: for most infobars, we shou…

Be more consistent about respecting link click dispositions in infobars: for most infobars, we should open with the desired disposition, unless it would overwrite the current window, in which case we use a new foreground tab.

BUG=none
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194480

[Elliot Glaysher, 2013-01-07 23:31:41]

lgtm

[Peter Kasting, 2013-01-19 01:47:38]

TBR=isherman for autofill OWNERS for this trivial change

[Ilya Sherman, 2013-01-19 02:16:34]

Do you want to update
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autoc...
as well?

[Peter Kasting, 2013-01-19 02:30:37]

On 2013/01/19 02:16:34, Ilya Sherman wrote:
> Do you want to update
>
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autoc...
> as well?

WHY ARE PEOPLE ADDING INFOBARS AND I AM NOT BEING ASKED TO REVIEW.  ARGH.

[Ilya Sherman, 2013-01-19 10:17:24]

(LGTM)

On 2013/01/19 02:30:37, Peter Kasting wrote:
> On 2013/01/19 02:16:34, Ilya Sherman wrote:
> > Do you want to update
> >
>
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autoc...
> > as well?
> 
> WHY ARE PEOPLE ADDING INFOBARS AND I AM NOT BEING ASKED TO REVIEW.  ARGH.

Probably because there's no automated tool that reminds people to include you on
the review?  I wasn't even aware that you wanted to be reviewing all
infobar-related code changes.

[Peter Kasting, 2013-01-21 06:13:22]

On 2013/01/19 10:17:24, Ilya Sherman wrote:
> > WHY ARE PEOPLE ADDING INFOBARS AND I AM NOT BEING ASKED TO REVIEW.  ARGH.
> 
> Probably because there's no automated tool that reminds people to include you
on
> the review?  I wasn't even aware that you wanted to be reviewing all
> infobar-related code changes.

Yeah, don't sweat it.  Not your fault and I was more faux-annoyed than
real-annoyed (a little bit of the latter... but as you noted, there's no
enforcement of this).

[Evan Stade, 2013-01-22 18:37:18]

why not add a watchlist so you're cc'd on all *infobar* changes?