Be more consistent about respecting link click dispositions in infobars: for most infobars, we shou…

chrome/browser/ui/sync/one_click_signin_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/sync/one_click_signin_helper.h"
 
 #include <algorithm>
 #include <functional>
 #include <utility>
 #include <vector>
@@ skipping 528 matching lines @@
 }
 
 string16 OneClickInfoBarDelegateImpl::GetLinkText() const {
   return l10n_util::GetStringUTF16(IDS_LEARN_MORE);
 }
 
 bool OneClickInfoBarDelegateImpl::LinkClicked(
     WindowOpenDisposition disposition) {
   RecordHistogramAction(one_click_signin::HISTOGRAM_LEARN_MORE);
   content::OpenURLParams params(
-      GURL(chrome::kChromeSyncLearnMoreURL), content::Referrer(), disposition,
+      GURL(chrome::kChromeSyncLearnMoreURL), content::Referrer(),
+      (disposition == CURRENT_TAB) ? NEW_FOREGROUND_TAB : disposition,
       content::PAGE_TRANSITION_LINK, false);
   owner()->GetWebContents()->OpenURL(params);
   return false;
 }
 
 void OneClickInfoBarDelegateImpl::GetAlternateColors(
     AlternateColors* alt_colors) {
   if (use_blue_on_white) {
     alt_colors->enabled = true;
     alt_colors->infobar_bottom_color = SK_ColorWHITE;
@@ skipping 828 matching lines @@
 
 void OneClickSigninHelper::SigninSuccess() {
   RedirectOnSigninComplete(true);
 }
 
 void OneClickSigninHelper::RedirectOnSigninComplete(bool show_bubble) {
   // Show the result in the sign-in bubble if desired.
   RedirectToNtpOrAppsPage(show_bubble);
   signin_tracker_.reset();
 }