Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: chrome/browser/autofill/autofill_cc_infobar_delegate.cc

Issue 11778029: Be more consistent about respecting link click dispositions in infobars: for most infobars, we shou… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/sync/one_click_signin_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/autofill_cc_infobar_delegate.cc
===================================================================
--- chrome/browser/autofill/autofill_cc_infobar_delegate.cc (revision 194436)
+++ chrome/browser/autofill/autofill_cc_infobar_delegate.cc (working copy)
@@ -110,11 +110,12 @@
bool AutofillCCInfoBarDelegate::LinkClicked(WindowOpenDisposition disposition) {
owner()->GetWebContents()->GetDelegate()->OpenURLFromTab(
owner()->GetWebContents(),
- content::OpenURLParams(GURL(autofill::kHelpURL),
- content::Referrer(),
- NEW_FOREGROUND_TAB,
- content::PAGE_TRANSITION_LINK,
- false));
+ content::OpenURLParams(
+ GURL(autofill::kHelpURL),
+ content::Referrer(),
+ (disposition == CURRENT_TAB) ? NEW_FOREGROUND_TAB : disposition,
+ content::PAGE_TRANSITION_LINK,
+ false));
return false;
}
« no previous file with comments | « no previous file | chrome/browser/ui/sync/one_click_signin_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698