chrome/browser/ui/sync/one_click_signin_helper.cc - Issue 11778029: Be more consistent about respecting link click dispositions in infobars: for most infobars, we shou…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper.cc

Issue 11778029: Be more consistent about respecting link click dispositions in infobars: for most infobars, we shou… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/sync/one_click_signin_helper.cc

===================================================================

--- chrome/browser/ui/sync/one_click_signin_helper.cc (revision 194436)

+++ chrome/browser/ui/sync/one_click_signin_helper.cc (working copy)

@@ -546,7 +546,8 @@

WindowOpenDisposition disposition) {

RecordHistogramAction(one_click_signin::HISTOGRAM_LEARN_MORE);

content::OpenURLParams params(

- GURL(chrome::kChromeSyncLearnMoreURL), content::Referrer(), disposition,

+ GURL(chrome::kChromeSyncLearnMoreURL), content::Referrer(),

+ (disposition == CURRENT_TAB) ? NEW_FOREGROUND_TAB : disposition,

content::PAGE_TRANSITION_LINK, false);

owner()->GetWebContents()->OpenURL(params);

return false;

« no previous file with comments | « chrome/browser/autofill/autofill_cc_infobar_delegate.cc ('k') | no next file » | no next file with comments »