Issue 1176583003: Move EqualsASCII to the base namespace.

Issue 1176583003: Move EqualsASCII to the base namespace. (Closed)

Created:
5 years, 6 months ago by brettw

Modified:
5 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, vabr+watchlist_chromium.org, nasko+codewatch_chromium.org, dcheng, dmazzoni+watch_chromium.org, cbentzel+watch_chromium.org, aboxhall+watch_chromium.org, grt+watch_chromium.org, jam, je_julie, darin-cc_chromium.org, erikwright+watch_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, yuzo+watch_chromium.org, gcasto+watchlist_chromium.org, mlamouri+watch-manifest_chromium.org, mkwst+watchlist-passwords_chromium.org, plundblad+watch_chromium.org, nektar+watch_chromium.org, dtseng+watch_chromium.org, Paweł Hajdan Jr., mkwst+moarreviews-renderer_chromium.org, jshin+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@string_util2

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Move EqualsASCII to the base namespace. Committed: https://crrev.com/00a56b7515b4cb34aa714da982c3553f28423558 Cr-Commit-Position: refs/heads/master@{#333676}

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -76 lines)			Patch
M	base/strings/string_util.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	base/strings/string_util.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/banners/app_banner_data_fetcher.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/net/proxy_browsertest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/net/websocket_browsertest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_mac.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/chrome_content_renderer_client.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/content_settings_observer.cc	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/renderer/net/net_error_helper.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/renderer/safe_browsing/phishing_classifier.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/web_apps.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/accessibility/browser_accessibility.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	content/browser/accessibility/browser_accessibility_android.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/manifest/manifest_browsertest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/child/ftp_directory_listing_response_delegate.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	content/common/page_state_serialization.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/drop_data_builder.cc	View		1 chunk	+7 lines, -4 lines	0 comments	Download
M	content/renderer/manifest/manifest_parser_unittest.cc	View		11 chunks	+31 lines, -26 lines	0 comments	Download
M	content/renderer/npapi/webplugin_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/render_frame_impl.cc	View	1	3 chunks	+5 lines, -4 lines	0 comments	Download
M	content/test/mock_webclipboard_impl.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/base/net_util_icu.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/ftp/ftp_directory_listing_parser_os2.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/ftp/ftp_directory_listing_parser_vms.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/ftp/ftp_directory_listing_parser_windows.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/ftp/ftp_util.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download