chrome/browser/password_manager/password_store_mac.cc - Issue 1176583003: Move EqualsASCII to the base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_mac.cc

Issue 1176583003: Move EqualsASCII to the base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@string_util2

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/password_manager/password_store_mac.cc

diff --git a/chrome/browser/password_manager/password_store_mac.cc b/chrome/browser/password_manager/password_store_mac.cc

index 46ba4d026831eecfaf6f0972b1c64520c327ea94..6d448d49ba56fbf5dcf8fd7c436ac4f53191683e 100644

--- a/chrome/browser/password_manager/password_store_mac.cc

+++ b/chrome/browser/password_manager/password_store_mac.cc

@@ -413,7 +413,7 @@ bool FillPasswordFormFromKeychainItem(const AppleKeychain& keychain,

// practice, other browsers seem to use a "" or " " password (and a special

// user name) to indicated blacklist entries.

if (extract_password_data && (form->password_value.empty() ||

- EqualsASCII(form->password_value, " "))) {

+ base::EqualsASCII(form->password_value, " "))) {

form->blacklisted_by_user = true;

}