chrome/browser/banners/app_banner_data_fetcher.cc - Issue 1176583003: Move EqualsASCII to the base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/banners/app_banner_data_fetcher.cc

Issue 1176583003: Move EqualsASCII to the base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@string_util2

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/banners/app_banner_data_fetcher.cc

diff --git a/chrome/browser/banners/app_banner_data_fetcher.cc b/chrome/browser/banners/app_banner_data_fetcher.cc

index 8507486b7dd56f534c17137f751a747bcba7bf5d..64eb8e077c7a9be4a4204c40f54e628379c02ddc 100644

--- a/chrome/browser/banners/app_banner_data_fetcher.cc

+++ b/chrome/browser/banners/app_banner_data_fetcher.cc

@@ -35,7 +35,7 @@ int gCurrentRequestID = -1;

const int kIconMinimumSize = 144;

bool DoesManifestContainRequiredIcon(const content::Manifest& manifest) {

for (const auto& icon : manifest.icons) {

- if (!EqualsASCII(icon.type.string(), "image/png"))

+ if (!base::EqualsASCII(icon.type.string(), "image/png"))

continue;

for (const auto& size : icon.sizes) {

« no previous file with comments | « base/strings/string_util.cc ('k') | chrome/browser/net/proxy_browsertest.cc » ('j') | no next file with comments »