Move EqualsASCII to the base namespace.

content/renderer/manifest/manifest_parser_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/manifest/manifest_parser.h"
 
 #include "base/strings/string_util.h"
 #include "content/public/common/manifest.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 109 matching lines @@
             errors()[4]);
   EXPECT_EQ("Manifest parsing error: property 'icons' ignored, "
             "type array expected.",
             errors()[5]);
 }
 
 TEST_F(ManifestParserTest, NameParseRules) {
   // Smoke test.
   {
     Manifest manifest = ParseManifest("{ \"name\": \"foo\" }");
-    ASSERT_TRUE(EqualsASCII(manifest.name.string(), "foo"));
+    ASSERT_TRUE(base::EqualsASCII(manifest.name.string(), "foo"));
     ASSERT_FALSE(manifest.IsEmpty());
     EXPECT_EQ(0u, GetErrorCount());
   }
 
   // Trim whitespaces.
   {
     Manifest manifest = ParseManifest("{ \"name\": \"  foo  \" }");
-    ASSERT_TRUE(EqualsASCII(manifest.name.string(), "foo"));
+    ASSERT_TRUE(base::EqualsASCII(manifest.name.string(), "foo"));
     EXPECT_EQ(0u, GetErrorCount());
   }
 
   // Don't parse if name isn't a string.
   {
     Manifest manifest = ParseManifest("{ \"name\": {} }");
     ASSERT_TRUE(manifest.name.is_null());
     EXPECT_EQ(1u, GetErrorCount());
     EXPECT_EQ("Manifest parsing error: property 'name' ignored,"
               " type string expected.",
               errors()[0]);
   }
 
   // Don't parse if name isn't a string.
   {
     Manifest manifest = ParseManifest("{ \"name\": 42 }");
     ASSERT_TRUE(manifest.name.is_null());
     EXPECT_EQ(1u, GetErrorCount());
     EXPECT_EQ("Manifest parsing error: property 'name' ignored,"
               " type string expected.",
               errors()[0]);
   }
 }
 
 TEST_F(ManifestParserTest, ShortNameParseRules) {
   // Smoke test.
   {
     Manifest manifest = ParseManifest("{ \"short_name\": \"foo\" }");
-    ASSERT_TRUE(EqualsASCII(manifest.short_name.string(), "foo"));
+    ASSERT_TRUE(base::EqualsASCII(manifest.short_name.string(), "foo"));
     ASSERT_FALSE(manifest.IsEmpty());
     EXPECT_EQ(0u, GetErrorCount());
   }
 
   // Trim whitespaces.
   {
     Manifest manifest = ParseManifest("{ \"short_name\": \"  foo  \" }");
-    ASSERT_TRUE(EqualsASCII(manifest.short_name.string(), "foo"));
+    ASSERT_TRUE(base::EqualsASCII(manifest.short_name.string(), "foo"));
     EXPECT_EQ(0u, GetErrorCount());
   }
 
   // Don't parse if name isn't a string.
   {
     Manifest manifest = ParseManifest("{ \"short_name\": {} }");
     ASSERT_TRUE(manifest.short_name.is_null());
     EXPECT_EQ(1u, GetErrorCount());
     EXPECT_EQ("Manifest parsing error: property 'short_name' ignored,"
               " type string expected.",
@@ skipping 375 matching lines @@
               "http://foo.com/landing/icons/foo.png");
     EXPECT_EQ(0u, GetErrorCount());
   }
 }
 
 TEST_F(ManifestParserTest, IconTypeParseRules) {
   // Smoke test.
   {
     Manifest manifest =
         ParseManifest("{ \"icons\": [ {\"src\": \"\", \"type\": \"foo\" } ] }");
-    EXPECT_TRUE(EqualsASCII(manifest.icons[0].type.string(), "foo"));
+    EXPECT_TRUE(base::EqualsASCII(manifest.icons[0].type.string(), "foo"));
     EXPECT_EQ(0u, GetErrorCount());
   }
 
   // Trim whitespaces.
   {
     Manifest manifest = ParseManifest("{ \"icons\": [ {\"src\": \"\","
                                       " \"type\": \"  foo  \" } ] }");
-    EXPECT_TRUE(EqualsASCII(manifest.icons[0].type.string(), "foo"));
+    EXPECT_TRUE(base::EqualsASCII(manifest.icons[0].type.string(), "foo"));
     EXPECT_EQ(0u, GetErrorCount());
   }
 
   // Don't parse if property isn't a string.
   {
     Manifest manifest =
         ParseManifest("{ \"icons\": [ {\"src\": \"\", \"type\": {} } ] }");
     EXPECT_TRUE(manifest.icons[0].type.is_null());
     EXPECT_EQ(1u, GetErrorCount());
     EXPECT_EQ("Manifest parsing error: property 'type' ignored,"
@@ skipping 263 matching lines @@
               "related application ignored.",
               errors()[0]);
   }
 
   // Valid application, with url.
   {
     Manifest manifest = ParseManifest(
         "{ \"related_applications\": ["
         "{\"platform\": \"play\", \"url\": \"http://www.foo.com\"}]}");
     EXPECT_EQ(manifest.related_applications.size(), 1u);
-    EXPECT_TRUE(EqualsASCII(manifest.related_applications[0].platform.string(),
-                            "play"));
+    EXPECT_TRUE(base::EqualsASCII(
+        manifest.related_applications[0].platform.string(),
+        "play"));
     EXPECT_EQ(manifest.related_applications[0].url.spec(),
               "http://www.foo.com/");
     EXPECT_FALSE(manifest.IsEmpty());
     EXPECT_EQ(0u, GetErrorCount());
   }
 
   // Valid application, with id.
   {
     Manifest manifest = ParseManifest(
         "{ \"related_applications\": ["
         "{\"platform\": \"itunes\", \"id\": \"foo\"}]}");
     EXPECT_EQ(manifest.related_applications.size(), 1u);
-    EXPECT_TRUE(EqualsASCII(manifest.related_applications[0].platform.string(),
-                            "itunes"));
-    EXPECT_TRUE(EqualsASCII(manifest.related_applications[0].id.string(),
-                            "foo"));
+    EXPECT_TRUE(base::EqualsASCII(
+        manifest.related_applications[0].platform.string(),
+        "itunes"));
+    EXPECT_TRUE(base::EqualsASCII(manifest.related_applications[0].id.string(),
+                                  "foo"));
     EXPECT_FALSE(manifest.IsEmpty());
     EXPECT_EQ(0u, GetErrorCount());
   }
 
   // All valid applications are in list.
   {
     Manifest manifest = ParseManifest(
         "{ \"related_applications\": ["
         "{\"platform\": \"play\", \"id\": \"foo\"},"
         "{\"platform\": \"itunes\", \"id\": \"bar\"}]}");
     EXPECT_EQ(manifest.related_applications.size(), 2u);
-    EXPECT_TRUE(EqualsASCII(manifest.related_applications[0].platform.string(),
-                            "play"));
-    EXPECT_TRUE(EqualsASCII(manifest.related_applications[0].id.string(),
-                            "foo"));
-    EXPECT_TRUE(EqualsASCII(manifest.related_applications[1].platform.string(),
-                            "itunes"));
-    EXPECT_TRUE(EqualsASCII(manifest.related_applications[1].id.string(),
-                            "bar"));
+    EXPECT_TRUE(base::EqualsASCII(
+        manifest.related_applications[0].platform.string(),
+        "play"));
+    EXPECT_TRUE(base::EqualsASCII(manifest.related_applications[0].id.string(),
+                                  "foo"));
+    EXPECT_TRUE(base::EqualsASCII(
+        manifest.related_applications[1].platform.string(),
+        "itunes"));
+    EXPECT_TRUE(base::EqualsASCII(manifest.related_applications[1].id.string(),
+                                  "bar"));
     EXPECT_FALSE(manifest.IsEmpty());
     EXPECT_EQ(0u, GetErrorCount());
   }
 
   // Two invalid applications and one valid. Only the valid application should
   // be in the list.
   {
     Manifest manifest = ParseManifest(
         "{ \"related_applications\": ["
         "{\"platform\": \"itunes\"},"
         "{\"platform\": \"play\", \"id\": \"foo\"},"
         "{}]}");
     EXPECT_EQ(manifest.related_applications.size(), 1u);
-    EXPECT_TRUE(EqualsASCII(manifest.related_applications[0].platform.string(),
-                            "play"));
-    EXPECT_TRUE(EqualsASCII(manifest.related_applications[0].id.string(),
-                            "foo"));
+    EXPECT_TRUE(base::EqualsASCII(
+        manifest.related_applications[0].platform.string(),
+        "play"));
+    EXPECT_TRUE(base::EqualsASCII(manifest.related_applications[0].id.string(),
+                                  "foo"));
     EXPECT_FALSE(manifest.IsEmpty());
     EXPECT_EQ(2u, GetErrorCount());
     EXPECT_EQ("Manifest parsing error: one of 'url' or 'id' is required, "
               "related application ignored.",
               errors()[0]);
     EXPECT_EQ("Manifest parsing error: 'platform' is a required field, "
               "related application ignored.",
               errors()[1]);
   }
 }
@@ skipping 44 matching lines @@
         ParseManifest("{ \"prefer_related_applications\": false }");
     EXPECT_FALSE(manifest.prefer_related_applications);
     EXPECT_EQ(0u, GetErrorCount());
   }
 }
 
 TEST_F(ManifestParserTest, GCMSenderIDParseRules) {
   // Smoke test.
   {
     Manifest manifest = ParseManifest("{ \"gcm_sender_id\": \"foo\" }");
-    EXPECT_TRUE(EqualsASCII(manifest.gcm_sender_id.string(), "foo"));
+    EXPECT_TRUE(base::EqualsASCII(manifest.gcm_sender_id.string(), "foo"));
     EXPECT_EQ(0u, GetErrorCount());
   }
 
   // Trim whitespaces.
   {
     Manifest manifest = ParseManifest("{ \"gcm_sender_id\": \"  foo  \" }");
-    EXPECT_TRUE(EqualsASCII(manifest.gcm_sender_id.string(), "foo"));
+    EXPECT_TRUE(base::EqualsASCII(manifest.gcm_sender_id.string(), "foo"));
     EXPECT_EQ(0u, GetErrorCount());
   }
 
   // Don't parse if the property isn't a string.
   {
     Manifest manifest = ParseManifest("{ \"gcm_sender_id\": {} }");
     EXPECT_TRUE(manifest.gcm_sender_id.is_null());
     EXPECT_EQ(1u, GetErrorCount());
     EXPECT_EQ("Manifest parsing error: property 'gcm_sender_id' ignored,"
               " type string expected.",
               errors()[0]);
   }
   {
     Manifest manifest = ParseManifest("{ \"gcm_sender_id\": 42 }");
     EXPECT_TRUE(manifest.gcm_sender_id.is_null());
     EXPECT_EQ(1u, GetErrorCount());
     EXPECT_EQ("Manifest parsing error: property 'gcm_sender_id' ignored,"
               " type string expected.",
               errors()[0]);
   }
 }
 
 } // namespace content