Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 11742005: Move [Homepage,Options,Update,DevTools]URL out of Extension (Closed)

Created:
7 years, 11 months ago by Devlin
Modified:
7 years, 11 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, vsevik, yurys, Aaron Boodman, pam+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, pfeldman, mhx348_motorola.com, SanjoyPal
Base URL:
http://git.chromium.org/chromium/src.git@dc_unref_browser_action
Visibility:
Public.

Description

Move [Homepage,Options,Update,DevTools]URL out of Extension This CL follows https://codereview.chromium.org/11644057/ (for thread-checking addition to finished_parsing_manifest_ CHECK in Extension) BUG=159265

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+604 lines, -384 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 2 chunks +8 lines, -5 lines 0 comments Download
A chrome/browser/extensions/api/extension_urls/extension_urls_api.h View 1 chunk +37 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/extension_urls/extension_urls_api.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_model.cc View 3 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_process_manager.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 4 chunks +12 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_sync_data.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/updater/extension_downloader.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_dependency_manager.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/themes/theme_syncable_service.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/themes/theme_syncable_service_unittest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/extension_app_item.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/extensions/application_launch.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 5 chunks +5 lines, -5 lines 0 comments Download
A chrome/common/extensions/api/extension_urls/devtools_manifest_unittest.cc View 1 chunk +35 lines, -0 lines 0 comments Download
A chrome/common/extensions/api/extension_urls/extension_urls_handler.h View 1 chunk +81 lines, -0 lines 0 comments Download
A chrome/common/extensions/api/extension_urls/extension_urls_handler.cc View 1 chunk +178 lines, -0 lines 0 comments Download
A + chrome/common/extensions/api/extension_urls/homepage_manifest_unittest.cc View 1 chunk +25 lines, -11 lines 0 comments Download
A + chrome/common/extensions/api/extension_urls/options_manifest_unittest.cc View 2 chunks +20 lines, -6 lines 0 comments Download
A + chrome/common/extensions/api/extension_urls/update_manifest_unittest.cc View 2 chunks +14 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension.h View 8 chunks +0 lines, -25 lines 0 comments Download
M chrome/common/extensions/extension.cc View 11 chunks +7 lines, -103 lines 0 comments Download
M chrome/common/extensions/extension_file_util.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension_unittest.cc View 34 chunks +41 lines, -33 lines 0 comments Download
D chrome/common/extensions/manifest_tests/extension_manifests_devtools_unittest.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/common/extensions/manifest_tests/extension_manifests_homepage_unittest.cc View 1 chunk +0 lines, -44 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc View 6 chunks +22 lines, -5 lines 0 comments Download
D chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/common/extensions/manifest_tests/extension_manifests_update_unittest.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/extensions/resource_request_policy.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Devlin
7 years, 11 months ago (2013-01-02 22:50:52 UTC) #1
Yoyo Zhou
I think we need a better way to coordinate. Joe Thomas has already started on ...
7 years, 11 months ago (2013-01-02 23:01:45 UTC) #2
Devlin
On 2013/01/02 23:01:45, Yoyo Zhou wrote: > I think we need a better way to ...
7 years, 11 months ago (2013-01-03 18:59:46 UTC) #3
Yoyo Zhou
7 years, 11 months ago (2013-01-04 22:44:26 UTC) #4
On 2013/01/03 18:59:46, D Cronin wrote:
> On 2013/01/02 23:01:45, Yoyo Zhou wrote:
> > I think we need a better way to coordinate. Joe Thomas has already
> > started on 3 out of these 4:
> > devtools: https://codereview.chromium.org/11624036/
> > options and update_url: https://codereview.chromium.org/11726002/
> 
> Is there a reason to keep this open, or is it safe to close the CL?

I think you can close it.

Powered by Google App Engine
This is Rietveld 408576698