Move [Homepage,Options,Update,DevTools]URL out of Extension

chrome/browser/extensions/api/management/management_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/management/management_api.h"
 
 #include <map>
 #include <string>
 #include <vector>
 
@@ skipping 11 matching lines @@
 #include "chrome/browser/extensions/event_router.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/extensions/extension_uninstall_dialog.h"
 #include "chrome/browser/extensions/management_policy.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/extensions/application_launch.h"
 #include "chrome/browser/ui/webui/extensions/extension_icon_source.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/chrome_utility_messages.h"
+#include "chrome/common/extensions/api/extension_urls/extension_urls_handler.h"
 #include "chrome/common/extensions/api/management.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "chrome/common/extensions/extension_icon_set.h"
 #include "chrome/common/extensions/permissions/permission_set.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/browser/utility_process_host.h"
 #include "content/public/browser/utility_process_host_client.h"
 #include "extensions/common/error_utils.h"
@@ skipping 47 matching lines @@
     ExtensionSystem* system) {
   scoped_ptr<management::ExtensionInfo> info(new management::ExtensionInfo());
   ExtensionService* service = system->extension_service();
 
   info->id = extension.id();
   info->name = extension.name();
   info->enabled = service->IsExtensionEnabled(info->id);
   info->offline_enabled = extension.offline_enabled();
   info->version = extension.VersionString();
   info->description = extension.description();
-  info->options_url = extension.options_url().spec();
+  info->options_url =
+      extensions::ExtensionURL::GetOptionsURL(&extension).spec();
   info->homepage_url.reset(new std::string(
-      extension.GetHomepageURL().spec()));
+      extensions::ExtensionURL::GetHomepageURL(&extension).spec()));
   info->may_disable = system->management_policy()->
       UserMayModifySettings(&extension, NULL);
   info->is_app = extension.is_app();
   if (info->is_app) {
     if (extension.is_legacy_packaged_app())
       info->type = ExtensionInfo::TYPE_LEGACY_PACKAGED_APP;
     else if (extension.is_hosted_app())
       info->type = ExtensionInfo::TYPE_HOSTED_APP;
     else
       info->type = ExtensionInfo::TYPE_PACKAGED_APP;
   } else if (extension.is_theme()) {
     info->type = ExtensionInfo::TYPE_THEME;
   } else {
     info->type = ExtensionInfo::TYPE_EXTENSION;
   }
 
   if (info->enabled) {
     info->disabled_reason = management::ExtensionInfo::DISABLED_REASON_NONE;
   } else {
     extensions::ExtensionPrefs* prefs = service->extension_prefs();
     if (prefs->DidExtensionEscalatePermissions(extension.id())) {
       info->disabled_reason =
           management::ExtensionInfo::DISABLED_REASON_PERMISSIONS_INCREASE;
     } else {
       info->disabled_reason =
           management::ExtensionInfo::DISABLED_REASON_UNKNOWN;
     }
   }
 
-  if (!extension.update_url().is_empty()) {
+  if (!extensions::ExtensionURL::GetUpdateURL(&extension).is_empty()) {
     info->update_url.reset(new std::string(
-        extension.update_url().spec()));
+        extensions::ExtensionURL::GetUpdateURL(&extension).spec()));
   }
 
   if (extension.is_app()) {
     info->app_launch_url.reset(new std::string(
         extension.GetFullLaunchURL().spec()));
   }
 
   const ExtensionIconSet::IconMap& icons = extension.icons().map();
   if (!icons.empty()) {
     info->icons.reset(new IconInfoList());
@@ skipping 528 matching lines @@
 
 void ExtensionManagementAPI::Shutdown() {
   ExtensionSystem::Get(profile_)->event_router()->UnregisterObserver(this);
 }
 
 void ExtensionManagementAPI::OnListenerAdded(
     const extensions::EventListenerInfo& details) {
   management_event_router_.reset(new ExtensionManagementEventRouter(profile_));
   ExtensionSystem::Get(profile_)->event_router()->UnregisterObserver(this);
 }