Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3114)

Unified Diff: chrome/common/extensions/api/extension_urls/update_manifest_unittest.cc

Issue 11742005: Move [Homepage,Options,Update,DevTools]URL out of Extension (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_browser_action
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/extension_urls/update_manifest_unittest.cc
diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_update_unittest.cc b/chrome/common/extensions/api/extension_urls/update_manifest_unittest.cc
similarity index 74%
rename from chrome/common/extensions/manifest_tests/extension_manifests_update_unittest.cc
rename to chrome/common/extensions/api/extension_urls/update_manifest_unittest.cc
index 6d396fe97c352f937403c269d8748caaba762b80..669f39909be11855148c947adebbf2464a147d2a 100644
--- a/chrome/common/extensions/manifest_tests/extension_manifests_update_unittest.cc
+++ b/chrome/common/extensions/api/extension_urls/update_manifest_unittest.cc
@@ -4,14 +4,23 @@
#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
+#include "chrome/common/extensions/api/extension_urls/extension_urls_handler.h"
#include "chrome/common/extensions/extension_manifest_constants.h"
+#include "chrome/common/extensions/manifest_handler.h"
#include "testing/gtest/include/gtest/gtest.h"
-using extensions::Extension;
+namespace extensions {
-namespace errors = extension_manifest_errors;
+class UpdateManifestTest : public ExtensionManifestTest {
+ protected:
+ virtual void SetUp() OVERRIDE {
+ ExtensionManifestTest::SetUp();
+ ManifestHandler::Register(extension_manifest_keys::kUpdateURL,
+ new UpdateURLHandler);
+ }
+};
-TEST_F(ExtensionManifestTest, UpdateUrls) {
+TEST_F(UpdateManifestTest, UpdateUrls) {
// Test several valid update urls
Testcase testcases[] = {
Testcase("update_url_valid_1.json", Extension::INTERNAL,
@@ -38,3 +47,5 @@ TEST_F(ExtensionManifestTest, UpdateUrls) {
RunTestcases(testcases2, arraysize(testcases2),
EXPECT_TYPE_ERROR);
}
+
+} // namespace extensions
« no previous file with comments | « chrome/common/extensions/api/extension_urls/options_manifest_unittest.cc ('k') | chrome/common/extensions/extension.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698