Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1590)

Side by Side Diff: chrome/common/extensions/api/extension_urls/update_manifest_unittest.cc

Issue 11742005: Move [Homepage,Options,Update,DevTools]URL out of Extension (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_browser_action
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
6 6
7 #include "chrome/common/extensions/api/extension_urls/extension_urls_handler.h"
7 #include "chrome/common/extensions/extension_manifest_constants.h" 8 #include "chrome/common/extensions/extension_manifest_constants.h"
9 #include "chrome/common/extensions/manifest_handler.h"
8 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
9 11
10 using extensions::Extension; 12 namespace extensions {
11 13
12 namespace errors = extension_manifest_errors; 14 class UpdateManifestTest : public ExtensionManifestTest {
15 protected:
16 virtual void SetUp() OVERRIDE {
17 ExtensionManifestTest::SetUp();
18 ManifestHandler::Register(extension_manifest_keys::kUpdateURL,
19 new UpdateURLHandler);
20 }
21 };
13 22
14 TEST_F(ExtensionManifestTest, UpdateUrls) { 23 TEST_F(UpdateManifestTest, UpdateUrls) {
15 // Test several valid update urls 24 // Test several valid update urls
16 Testcase testcases[] = { 25 Testcase testcases[] = {
17 Testcase("update_url_valid_1.json", Extension::INTERNAL, 26 Testcase("update_url_valid_1.json", Extension::INTERNAL,
18 Extension::NO_FLAGS), 27 Extension::NO_FLAGS),
19 Testcase("update_url_valid_2.json", Extension::INTERNAL, 28 Testcase("update_url_valid_2.json", Extension::INTERNAL,
20 Extension::NO_FLAGS), 29 Extension::NO_FLAGS),
21 Testcase("update_url_valid_3.json", Extension::INTERNAL, 30 Testcase("update_url_valid_3.json", Extension::INTERNAL,
22 Extension::NO_FLAGS), 31 Extension::NO_FLAGS),
23 Testcase("update_url_valid_4.json", Extension::INTERNAL, 32 Testcase("update_url_valid_4.json", Extension::INTERNAL,
24 Extension::NO_FLAGS) 33 Extension::NO_FLAGS)
25 }; 34 };
26 RunTestcases(testcases, arraysize(testcases), 35 RunTestcases(testcases, arraysize(testcases),
27 EXPECT_TYPE_SUCCESS); 36 EXPECT_TYPE_SUCCESS);
28 37
29 // Test some invalid update urls 38 // Test some invalid update urls
30 Testcase testcases2[] = { 39 Testcase testcases2[] = {
31 Testcase("update_url_invalid_1.json", errors::kInvalidUpdateURL, 40 Testcase("update_url_invalid_1.json", errors::kInvalidUpdateURL,
32 Extension::INTERNAL, Extension::NO_FLAGS), 41 Extension::INTERNAL, Extension::NO_FLAGS),
33 Testcase("update_url_invalid_2.json", errors::kInvalidUpdateURL, 42 Testcase("update_url_invalid_2.json", errors::kInvalidUpdateURL,
34 Extension::INTERNAL, Extension::NO_FLAGS), 43 Extension::INTERNAL, Extension::NO_FLAGS),
35 Testcase("update_url_invalid_3.json", errors::kInvalidUpdateURL, 44 Testcase("update_url_invalid_3.json", errors::kInvalidUpdateURL,
36 Extension::INTERNAL, Extension::NO_FLAGS) 45 Extension::INTERNAL, Extension::NO_FLAGS)
37 }; 46 };
38 RunTestcases(testcases2, arraysize(testcases2), 47 RunTestcases(testcases2, arraysize(testcases2),
39 EXPECT_TYPE_ERROR); 48 EXPECT_TYPE_ERROR);
40 } 49 }
50
51 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/common/extensions/api/extension_urls/options_manifest_unittest.cc ('k') | chrome/common/extensions/extension.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698