|
Remove one more use of mirrors: Components now have to explicitly sync their fields.
This also removes one bit of magic to make it more obvious what on is
going on during a sync, which should hopefully help.
Components have to decide if they support being stateful or not. If
they do, then they must implement syncFields() and have mutable
fields; if they don't, then they must have final fields. This isn't
particularly enforced, though.
This also renames _willSync() to _retainStatefulNodeIfPossible(), for
clarity, and fixes some minor style issues and one typo that was
breaking the drawer.
R=abarth@chromium.org
Committed: https://chromium.googlesource.com/external/mojo/+/3bacbb2f7b295147c4201c66868805e954b2dbb7
Total comments: 1
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+149 lines, -64 lines) |
Patch |
 |
M |
sky/examples/stocks2/lib/stock_app.dart
|
View
|
1
2
3
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
sky/examples/stocks2/lib/stock_arrow.dart
|
View
|
1
2
3
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
sky/examples/stocks2/lib/stock_list.dart
|
View
|
1
|
2 chunks |
+9 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sky/examples/stocks2/lib/stock_menu.dart
|
View
|
1
2
3
|
1 chunk |
+7 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sky/examples/stocks2/lib/stock_row.dart
|
View
|
1
2
3
|
1 chunk |
+4 lines, -5 lines |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/framework/components2/animated_component.dart
|
View
|
1
2
3
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/framework/components2/button.dart
|
View
|
1
2
3
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/framework/components2/button_base.dart
|
View
|
1
2
3
|
2 chunks |
+16 lines, -11 lines |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/framework/components2/checkbox.dart
|
View
|
1
|
1 chunk |
+6 lines, -0 lines |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/framework/components2/drawer.dart
|
View
|
1
|
1 chunk |
+7 lines, -0 lines |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/framework/components2/drawer_header.dart
|
View
|
1
2
3
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/framework/components2/fixed_height_scrollable.dart
|
View
|
1
2
3
|
5 chunks |
+16 lines, -9 lines |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/framework/components2/floating_action_button.dart
|
View
|
1
2
3
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/framework/components2/icon.dart
|
View
|
1
2
3
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/framework/components2/icon_button.dart
|
View
|
1
2
3
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/framework/components2/ink_well.dart
|
View
|
1
2
3
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/framework/components2/input.dart
|
View
|
1
|
1 chunk |
+8 lines, -1 line |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/framework/components2/material.dart
|
View
|
1
2
3
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/framework/components2/menu_item.dart
|
View
|
1
|
2 chunks |
+9 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/framework/components2/modal_overlay.dart
|
View
|
1
2
3
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/framework/components2/popup_menu.dart
|
View
|
1
|
1 chunk |
+8 lines, -1 line |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/framework/components2/popup_menu_item.dart
|
View
|
1
2
3
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/framework/components2/radio.dart
|
View
|
1
|
1 chunk |
+9 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/framework/components2/scrollable.dart
|
View
|
1
2
3
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/framework/components2/tool_bar.dart
|
View
|
1
2
3
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/framework/fn2.dart
|
View
|
1
2
3
|
4 chunks |
+19 lines, -6 lines |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/framework/rendering/box.dart
|
View
|
1
2
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 3 (1 generated)
|