sky/sdk/lib/framework/components2/icon_button.dart - Issue 1174023003: Remove one more use of mirrors: Components now have to explicitly sync their fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/framework/components2/icon_button.dart

Issue 1174023003: Remove one more use of mirrors: Components now have to explicitly sync their fields. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/sdk/lib/framework/components2/icon_button.dart

diff --git a/sky/sdk/lib/framework/components2/icon_button.dart b/sky/sdk/lib/framework/components2/icon_button.dart

index b7b7deefcdd60c9a3a2370216d3dba4d22a7bff2..d404be632cea8b016a2344aaaebc74ddca73036b 100644

--- a/sky/sdk/lib/framework/components2/icon_button.dart

+++ b/sky/sdk/lib/framework/components2/icon_button.dart

@@ -11,8 +11,8 @@ class IconButton extends Component {

IconButton({ String icon: '', this.onGestureTap })

: super(key: icon), icon = icon;

- String icon;

- GestureEventListener onGestureTap;

+ final String icon;

+ final GestureEventListener onGestureTap;

UINode build() {

return new EventListenerNode(

« no previous file with comments | « sky/sdk/lib/framework/components2/icon.dart ('k') | sky/sdk/lib/framework/components2/ink_well.dart » ('j') | no next file with comments »