Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1040)

Unified Diff: sky/sdk/lib/framework/components2/scrollable.dart

Issue 1174023003: Remove one more use of mirrors: Components now have to explicitly sync their fields. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/lib/framework/components2/radio.dart ('k') | sky/sdk/lib/framework/components2/tool_bar.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/framework/components2/scrollable.dart
diff --git a/sky/sdk/lib/framework/components2/scrollable.dart b/sky/sdk/lib/framework/components2/scrollable.dart
index bc76e4026345c1523dff20eeb3ea371b604d7bdc..b43583325d934573a60ccf0bc7425b7125fae87c 100644
--- a/sky/sdk/lib/framework/components2/scrollable.dart
+++ b/sky/sdk/lib/framework/components2/scrollable.dart
@@ -23,10 +23,12 @@ abstract class ScrollClient {
abstract class Scrollable extends Component {
- Scrollable({Object key}) : super(key: key) {
+ Scrollable({Object key}) : super(key: key, stateful: true) {
onDidUnmount(_stopSimulation);
}
+ void syncFields(Scrollable source) { }
+
double _scrollOffset = 0.0;
double get scrollOffset => _scrollOffset;
« no previous file with comments | « sky/sdk/lib/framework/components2/radio.dart ('k') | sky/sdk/lib/framework/components2/tool_bar.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698