Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: sky/sdk/lib/framework/components2/popup_menu.dart

Issue 1174023003: Remove one more use of mirrors: Components now have to explicitly sync their fields. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/sdk/lib/framework/components2/popup_menu.dart
diff --git a/sky/sdk/lib/framework/components2/popup_menu.dart b/sky/sdk/lib/framework/components2/popup_menu.dart
index 760f0e2d4434093f2340b3aaa25f111a96fcf707..e11a528e2f1d50771657c7af6aefa15d57b3fa8c 100644
--- a/sky/sdk/lib/framework/components2/popup_menu.dart
+++ b/sky/sdk/lib/framework/components2/popup_menu.dart
@@ -60,9 +60,16 @@ class PopupMenu extends AnimatedComponent {
// onDidMount(_measureSize);
}
+ PopupMenuController controller;
List<List<UINode>> items;
int level;
- PopupMenuController controller;
+
+ void syncFields(PopupMenu source) {
+ controller = source.controller;
+ items = source.items;
+ level = source.level;
+ super.syncFields(source);
+ }
double _position;
// int _width;
« no previous file with comments | « sky/sdk/lib/framework/components2/modal_overlay.dart ('k') | sky/sdk/lib/framework/components2/popup_menu_item.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698