Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: sync/internal_api/base_node.cc

Issue 1172153007: [Sync] Clean up obsolete datatype specific methods in sync api (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/base_node.cc
diff --git a/sync/internal_api/base_node.cc b/sync/internal_api/base_node.cc
index 4d6d56fadbe88df2921a15c9b114d5595168158b..640554bdfa53bd83ba947d583ec6ca4a7579b375 100644
--- a/sync/internal_api/base_node.cc
+++ b/sync/internal_api/base_node.cc
@@ -218,21 +218,6 @@ int64 BaseNode::GetExternalId() const {
return GetEntry()->GetLocalExternalId();
}
-const sync_pb::AppSpecifics& BaseNode::GetAppSpecifics() const {
- DCHECK_EQ(GetModelType(), APPS);
- return GetEntitySpecifics().app();
-}
-
-const sync_pb::AutofillSpecifics& BaseNode::GetAutofillSpecifics() const {
- DCHECK_EQ(GetModelType(), AUTOFILL);
- return GetEntitySpecifics().autofill();
-}
-
-const AutofillProfileSpecifics& BaseNode::GetAutofillProfileSpecifics() const {
- DCHECK_EQ(GetModelType(), AUTOFILL_PROFILE);
- return GetEntitySpecifics().autofill_profile();
-}
-
const sync_pb::BookmarkSpecifics& BaseNode::GetBookmarkSpecifics() const {
DCHECK_EQ(GetModelType(), BOOKMARKS);
return GetEntitySpecifics().bookmark();
@@ -248,42 +233,16 @@ const sync_pb::PasswordSpecificsData& BaseNode::GetPasswordSpecifics() const {
return *password_data_;
}
-const sync_pb::ThemeSpecifics& BaseNode::GetThemeSpecifics() const {
- DCHECK_EQ(GetModelType(), THEMES);
- return GetEntitySpecifics().theme();
-}
-
const sync_pb::TypedUrlSpecifics& BaseNode::GetTypedUrlSpecifics() const {
DCHECK_EQ(GetModelType(), TYPED_URLS);
return GetEntitySpecifics().typed_url();
}
-const sync_pb::ExtensionSpecifics& BaseNode::GetExtensionSpecifics() const {
- DCHECK_EQ(GetModelType(), EXTENSIONS);
- return GetEntitySpecifics().extension();
-}
-
-const sync_pb::SessionSpecifics& BaseNode::GetSessionSpecifics() const {
- DCHECK_EQ(GetModelType(), SESSIONS);
- return GetEntitySpecifics().session();
-}
-
-const sync_pb::DeviceInfoSpecifics& BaseNode::GetDeviceInfoSpecifics() const {
- DCHECK_EQ(GetModelType(), DEVICE_INFO);
- return GetEntitySpecifics().device_info();
-}
-
const sync_pb::ExperimentsSpecifics& BaseNode::GetExperimentsSpecifics() const {
DCHECK_EQ(GetModelType(), EXPERIMENTS);
return GetEntitySpecifics().experiments();
}
-const sync_pb::PriorityPreferenceSpecifics&
- BaseNode::GetPriorityPreferenceSpecifics() const {
- DCHECK_EQ(GetModelType(), PRIORITY_PREFERENCES);
- return GetEntitySpecifics().priority_preference();
-}
-
const sync_pb::EntitySpecifics& BaseNode::GetEntitySpecifics() const {
return GetUnencryptedSpecifics(GetEntry());
}

Powered by Google App Engine
This is Rietveld 408576698