Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Unified Diff: sync/internal_api/public/base_node.h

Issue 1172153007: [Sync] Clean up obsolete datatype specific methods in sync api (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/public/base_node.h
diff --git a/sync/internal_api/public/base_node.h b/sync/internal_api/public/base_node.h
index 93d2baf72eeddc7b4145c2d670e4c328c04acbcd..93ede5b86c37a3d2acfe5d7e8417adc2fbe03836 100644
--- a/sync/internal_api/public/base_node.h
+++ b/sync/internal_api/public/base_node.h
@@ -115,17 +115,6 @@ class SYNC_EXPORT BaseNode {
// data. Can only be called if GetModelType() == BOOKMARK.
const sync_pb::BookmarkSpecifics& GetBookmarkSpecifics() const;
- // Getter specific to the APPS datatype. Returns protobuf
- // data. Can only be called if GetModelType() == APPS.
- const sync_pb::AppSpecifics& GetAppSpecifics() const;
-
- // Getter specific to the AUTOFILL datatype. Returns protobuf
- // data. Can only be called if GetModelType() == AUTOFILL.
- const sync_pb::AutofillSpecifics& GetAutofillSpecifics() const;
-
- virtual const sync_pb::AutofillProfileSpecifics&
- GetAutofillProfileSpecifics() const;
-
// Getter specific to the NIGORI datatype. Returns protobuf
// data. Can only be called if GetModelType() == NIGORI.
const sync_pb::NigoriSpecifics& GetNigoriSpecifics() const;
@@ -134,39 +123,14 @@ class SYNC_EXPORT BaseNode {
// data. Can only be called if GetModelType() == PASSWORD.
const sync_pb::PasswordSpecificsData& GetPasswordSpecifics() const;
- // Getter specific to the PREFERENCE datatype. Returns protobuf
- // data. Can only be called if GetModelType() == PREFERENCE.
- const sync_pb::PreferenceSpecifics& GetPreferenceSpecifics() const;
-
- // Getter specific to the THEME datatype. Returns protobuf
- // data. Can only be called if GetModelType() == THEME.
- const sync_pb::ThemeSpecifics& GetThemeSpecifics() const;
-
// Getter specific to the TYPED_URLS datatype. Returns protobuf
// data. Can only be called if GetModelType() == TYPED_URLS.
const sync_pb::TypedUrlSpecifics& GetTypedUrlSpecifics() const;
- // Getter specific to the EXTENSIONS datatype. Returns protobuf
- // data. Can only be called if GetModelType() == EXTENSIONS.
- const sync_pb::ExtensionSpecifics& GetExtensionSpecifics() const;
-
- // Getter specific to the SESSIONS datatype. Returns protobuf
- // data. Can only be called if GetModelType() == SESSIONS.
- const sync_pb::SessionSpecifics& GetSessionSpecifics() const;
-
- // Getter specific to the DEVICE_INFO datatype. Returns protobuf
- // data. Can only be called if GetModelType() == DEVICE_INFO.
- const sync_pb::DeviceInfoSpecifics& GetDeviceInfoSpecifics() const;
-
// Getter specific to the EXPERIMENTS datatype. Returns protobuf
// data. Can only be called if GetModelType() == EXPERIMENTS.
const sync_pb::ExperimentsSpecifics& GetExperimentsSpecifics() const;
- // Getter specific to the PRIORITY_PREFERENCE datatype. Returns protobuf
- // data. Can only be called if GetModelType() == PRIORITY_PREFERENCE.
- const sync_pb::PriorityPreferenceSpecifics&
- GetPriorityPreferenceSpecifics() const;
-
const sync_pb::EntitySpecifics& GetEntitySpecifics() const;
// Returns the local external ID associated with the node.

Powered by Google App Engine
This is Rietveld 408576698