Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7178)

Unified Diff: chrome/browser/sync/profile_sync_service_autofill_unittest.cc

Issue 1172153007: [Sync] Clean up obsolete datatype specific methods in sync api (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sync/internal_api/base_node.cc » ('j') | sync/internal_api/write_node.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/profile_sync_service_autofill_unittest.cc
diff --git a/chrome/browser/sync/profile_sync_service_autofill_unittest.cc b/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
index e0110459e07771d8527ac8383a4d04795116cf41..31d8fd6810fdced791c53c9c1aa5cfe38bd663dd 100644
--- a/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
+++ b/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
@@ -596,9 +596,7 @@ class ProfileSyncServiceAutofillTest
sync_pb::EntitySpecifics specifics;
AutocompleteSyncableService::WriteAutofillEntry(entry, &specifics);
- sync_pb::AutofillSpecifics* autofill_specifics =
- specifics.mutable_autofill();
- node.SetAutofillSpecifics(*autofill_specifics);
+ node.SetEntitySpecifics(specifics);
return true;
}
@@ -618,9 +616,7 @@ class ProfileSyncServiceAutofillTest
sync_pb::EntitySpecifics specifics;
AutofillProfileSyncableService::WriteAutofillProfile(profile, &specifics);
- sync_pb::AutofillProfileSpecifics* profile_specifics =
- specifics.mutable_autofill_profile();
- node.SetAutofillProfileSpecifics(*profile_specifics);
+ node.SetEntitySpecifics(specifics);
return true;
}
@@ -639,7 +635,7 @@ class ProfileSyncServiceAutofillTest
return false;
const sync_pb::AutofillSpecifics& autofill(
- child_node.GetAutofillSpecifics());
+ child_node.GetEntitySpecifics().autofill());
if (autofill.has_value()) {
AutofillKey key(base::UTF8ToUTF16(autofill.name()),
base::UTF8ToUTF16(autofill.value()));
@@ -678,7 +674,7 @@ class ProfileSyncServiceAutofillTest
return false;
const sync_pb::AutofillProfileSpecifics& autofill(
- child_node.GetAutofillProfileSpecifics());
+ child_node.GetEntitySpecifics().autofill_profile());
AutofillProfile p;
p.set_guid(autofill.guid());
AutofillProfileSyncableService::OverwriteProfileWithServerData(
« no previous file with comments | « no previous file | sync/internal_api/base_node.cc » ('j') | sync/internal_api/write_node.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698