Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: sync/internal_api/write_node.cc

Issue 1172153007: [Sync] Clean up obsolete datatype specific methods in sync api (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/internal_api/public/write_node.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/write_node.cc
diff --git a/sync/internal_api/write_node.cc b/sync/internal_api/write_node.cc
index cefe8547e12108a4200fd466a59312798bf5496a..888e706996a6aa9d654b6bf07fbf44e2eb910756 100644
--- a/sync/internal_api/write_node.cc
+++ b/sync/internal_api/write_node.cc
@@ -10,13 +10,7 @@
#include "sync/internal_api/public/base_transaction.h"
#include "sync/internal_api/public/write_transaction.h"
#include "sync/internal_api/syncapi_internal.h"
-#include "sync/protocol/app_specifics.pb.h"
-#include "sync/protocol/autofill_specifics.pb.h"
#include "sync/protocol/bookmark_specifics.pb.h"
-#include "sync/protocol/extension_specifics.pb.h"
-#include "sync/protocol/password_specifics.pb.h"
-#include "sync/protocol/session_specifics.pb.h"
-#include "sync/protocol/theme_specifics.pb.h"
#include "sync/protocol/typed_url_specifics.pb.h"
#include "sync/syncable/mutable_entry.h"
#include "sync/syncable/nigori_util.h"
@@ -110,28 +104,6 @@ void WriteNode::SetTitle(const std::string& title) {
MarkForSyncing();
}
-void WriteNode::SetAppSpecifics(
- const sync_pb::AppSpecifics& new_value) {
- sync_pb::EntitySpecifics entity_specifics;
- entity_specifics.mutable_app()->CopyFrom(new_value);
- SetEntitySpecifics(entity_specifics);
-}
-
-void WriteNode::SetAutofillSpecifics(
- const sync_pb::AutofillSpecifics& new_value) {
- sync_pb::EntitySpecifics entity_specifics;
- entity_specifics.mutable_autofill()->CopyFrom(new_value);
- SetEntitySpecifics(entity_specifics);
-}
-
-void WriteNode::SetAutofillProfileSpecifics(
- const sync_pb::AutofillProfileSpecifics& new_value) {
- sync_pb::EntitySpecifics entity_specifics;
- entity_specifics.mutable_autofill_profile()->
- CopyFrom(new_value);
- SetEntitySpecifics(entity_specifics);
-}
-
void WriteNode::SetBookmarkSpecifics(
const sync_pb::BookmarkSpecifics& new_value) {
sync_pb::EntitySpecifics entity_specifics;
@@ -175,41 +147,6 @@ void WriteNode::SetPasswordSpecifics(
SetEntitySpecifics(entity_specifics);
}
-void WriteNode::SetThemeSpecifics(
- const sync_pb::ThemeSpecifics& new_value) {
- sync_pb::EntitySpecifics entity_specifics;
- entity_specifics.mutable_theme()->CopyFrom(new_value);
- SetEntitySpecifics(entity_specifics);
-}
-
-void WriteNode::SetSessionSpecifics(
- const sync_pb::SessionSpecifics& new_value) {
- sync_pb::EntitySpecifics entity_specifics;
- entity_specifics.mutable_session()->CopyFrom(new_value);
- SetEntitySpecifics(entity_specifics);
-}
-
-void WriteNode::SetDeviceInfoSpecifics(
- const sync_pb::DeviceInfoSpecifics& new_value) {
- sync_pb::EntitySpecifics entity_specifics;
- entity_specifics.mutable_device_info()->CopyFrom(new_value);
- SetEntitySpecifics(entity_specifics);
-}
-
-void WriteNode::SetExperimentsSpecifics(
- const sync_pb::ExperimentsSpecifics& new_value) {
- sync_pb::EntitySpecifics entity_specifics;
- entity_specifics.mutable_experiments()->CopyFrom(new_value);
- SetEntitySpecifics(entity_specifics);
-}
-
-void WriteNode::SetPriorityPreferenceSpecifics(
- const sync_pb::PriorityPreferenceSpecifics& new_value) {
- sync_pb::EntitySpecifics entity_specifics;
- entity_specifics.mutable_priority_preference()->CopyFrom(new_value);
- SetEntitySpecifics(entity_specifics);
-}
-
void WriteNode::SetEntitySpecifics(
const sync_pb::EntitySpecifics& new_value) {
ModelType new_specifics_type =
@@ -256,13 +193,6 @@ void WriteNode::SetTypedUrlSpecifics(
SetEntitySpecifics(entity_specifics);
}
-void WriteNode::SetExtensionSpecifics(
- const sync_pb::ExtensionSpecifics& new_value) {
- sync_pb::EntitySpecifics entity_specifics;
- entity_specifics.mutable_extension()->CopyFrom(new_value);
- SetEntitySpecifics(entity_specifics);
-}
-
void WriteNode::SetExternalId(int64 id) {
if (GetExternalId() != id)
entry_->PutLocalExternalId(id);
« no previous file with comments | « sync/internal_api/public/write_node.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698