Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1172153007: [Sync] Clean up obsolete datatype specific methods in sync api (Closed)

Created:
5 years, 6 months ago by Nicolas Zea
Modified:
5 years, 6 months ago
Reviewers:
stanisc
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Clean up obsolete datatype specific methods in sync api These datatype specifics methods were no longer in use anywhere. BUG=none Committed: https://crrev.com/7f0265b658026135a99835f0e9696e28158387f1 Cr-Commit-Position: refs/heads/master@{#333820}

Patch Set 1 #

Patch Set 2 : Fix tests #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -197 lines) Patch
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 4 chunks +4 lines, -8 lines 0 comments Download
M sync/internal_api/base_node.cc View 2 chunks +0 lines, -41 lines 0 comments Download
M sync/internal_api/public/base_node.h View 2 chunks +0 lines, -36 lines 0 comments Download
M sync/internal_api/public/write_node.h View 3 chunks +0 lines, -42 lines 0 comments Download
M sync/internal_api/write_node.cc View 4 chunks +0 lines, -70 lines 1 comment Download

Messages

Total messages: 9 (2 generated)
Nicolas Zea
PTAL
5 years, 6 months ago (2015-06-10 04:13:36 UTC) #2
Nicolas Zea
Tests fixed
5 years, 6 months ago (2015-06-10 18:27:03 UTC) #3
stanisc
lgtm https://codereview.chromium.org/1172153007/diff/20001/sync/internal_api/write_node.cc File sync/internal_api/write_node.cc (left): https://codereview.chromium.org/1172153007/diff/20001/sync/internal_api/write_node.cc#oldcode252 sync/internal_api/write_node.cc:252: void WriteNode::SetTypedUrlSpecifics( Consider removing this one as well. ...
5 years, 6 months ago (2015-06-10 21:53:38 UTC) #4
Nicolas Zea
On 2015/06/10 21:53:38, stanisc wrote: > lgtm > > https://codereview.chromium.org/1172153007/diff/20001/sync/internal_api/write_node.cc > File sync/internal_api/write_node.cc (left): > ...
5 years, 6 months ago (2015-06-10 21:54:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172153007/20001
5 years, 6 months ago (2015-06-10 21:55:48 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-10 22:36:26 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 22:37:20 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/7f0265b658026135a99835f0e9696e28158387f1
Cr-Commit-Position: refs/heads/master@{#333820}

Powered by Google App Engine
This is Rietveld 408576698