Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1542)

Issue 1169823005: Add sidebar views implementation using ExtensionSystem SidebarManager

Created:
5 years, 6 months ago by ltilve
Modified:
5 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org, ben6
Base URL:
https://chromium.googlesource.com/chromium/src.git@patch-a
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add sidebar views implementation using ExtensionSystem SidebarManager Allow browser extension actions to show their popup inside a SidebarContainer. BUG=477424

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : Rebased patch set to 1168383002/#ps220001 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -17 lines) Patch
M chrome/browser/ui/browser_ui_prefs.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/extensions/extension_action_platform_delegate.h View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/extensions/extension_action_view_controller.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/view_ids.h View 2 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.h View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.cc View 1 2 3 4 5 6 7 8 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 2 3 4 5 6 7 8 9 10 8 chunks +16 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 4 5 6 7 8 9 10 8 chunks +95 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view_layout.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 4 (1 generated)
ltilve
Add sidebar views to support extensions showing their popup contents into a sidebar. Depends on ...
5 years, 6 months ago (2015-06-09 09:52:47 UTC) #2
benjamin.j.mccann
Thanks for the reviews on https://codereview.chromium.org/1168383002/! I was wondering if it might make sense to ...
5 years, 5 months ago (2015-07-10 19:45:56 UTC) #3
Devlin
5 years, 5 months ago (2015-07-10 20:20:58 UTC) #4
On 2015/07/10 19:45:56, benjamin.j.mccann wrote:
> Thanks for the reviews on https://codereview.chromium.org/1168383002/! I was
> wondering if it might make sense to do a round of review on this one as well
> while that's pending so that we can keep busy addressing anything that's known
> while the ball's out of our court on 1168383002

My concern is mostly that these CLs depend pretty heavily on the first one, so
any comments made on this CL would be potentially moot with the changes in the
other.  I'd prefer to get the first one stable, and then work on these.  (That
said, the views and cocoa implementations can probably be reviewed in parallel,
since they have very little overlap.)

Powered by Google App Engine
This is Rietveld 408576698