Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3345)

Unified Diff: chrome/browser/ui/extensions/extension_action_view_controller.cc

Issue 1169823005: Add sidebar views implementation using ExtensionSystem SidebarManager Base URL: https://chromium.googlesource.com/chromium/src.git@patch-a
Patch Set: Rebased patch set to 1168383002/#ps220001 Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/extensions/extension_action_platform_delegate.h ('k') | chrome/browser/ui/view_ids.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/extensions/extension_action_view_controller.cc
diff --git a/chrome/browser/ui/extensions/extension_action_view_controller.cc b/chrome/browser/ui/extensions/extension_action_view_controller.cc
index 984ed1eccf0e0895e05aea5865be079c24fefbd0..1f16b506005ebac0eb811e0395c398993279004e 100644
--- a/chrome/browser/ui/extensions/extension_action_view_controller.cc
+++ b/chrome/browser/ui/extensions/extension_action_view_controller.cc
@@ -350,6 +350,8 @@ bool ExtensionActionViewController::TriggerSidebarWithUrl(
DCHECK(toolbar_actions_bar_);
toolbar_actions_bar_->SetSidebarOwner(this);
+ platform_delegate_->ShowSidebar(sidebar_host_->host_contents());
+
PressButtonWithSlideOutIfEnabled(
base::Bind(&ExtensionActionViewController::PressButton,
weak_factory_.GetWeakPtr(), true));
@@ -390,6 +392,8 @@ void ExtensionActionViewController::HideSidebar() {
if (!sidebar_host_)
return;
+ platform_delegate_->HideSidebar();
+
sidebar_host_.reset();
if (toolbar_actions_bar_)
toolbar_actions_bar_->SetSidebarOwner(nullptr);
« no previous file with comments | « chrome/browser/ui/extensions/extension_action_platform_delegate.h ('k') | chrome/browser/ui/view_ids.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698