chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.cc - Issue 1169823005: Add sidebar views implementation using ExtensionSystem SidebarManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.cc

Issue 1169823005: Add sidebar views implementation using ExtensionSystem SidebarManager Base URL: https://chromium.googlesource.com/chromium/src.git@patch-a

Patch Set: Rebased patch set to 1168383002/#ps220001 Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.h ('k') | chrome/browser/ui/views/frame/browser_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.cc

diff --git a/chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.cc b/chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.cc

index 17c617e4e15878ba305c1f4a62ba9641bc30d512..583ee65b38d95deaa7e0856882aaf5b09c396ae9 100644

--- a/chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.cc

+++ b/chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.cc

@@ -94,6 +94,16 @@ void ExtensionActionPlatformDelegateViews::CloseOverflowMenu() {

toolbar->CloseAppMenu();

}

+void ExtensionActionPlatformDelegateViews::ShowSidebar(

+ content::WebContents* sidebar_contents) {

+ BrowserView::GetBrowserViewForBrowser(controller_->browser())

+ ->ShowSidebar(sidebar_contents);

+void ExtensionActionPlatformDelegateViews::HideSidebar() {

+ BrowserView::GetBrowserViewForBrowser(controller_->browser())->HideSidebar();

void ExtensionActionPlatformDelegateViews::Observe(

int type,

const content::NotificationSource& source,