Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Issue 1169813009: Add TODOs about components needing to adjust to screen size changes. (Closed)

Created:
5 years, 6 months ago by eseidel
Modified:
5 years, 6 months ago
Reviewers:
Hixie
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add TODOs about components needing to adjust to screen size changes. Our current static view_configuration design cannot work. https://github.com/domokit/mojo/issues/231 R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/6f750c7bb5a9c80fea1d02d0bce1abdcd9a4e82e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M sky/sdk/lib/framework/components2/drawer.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/components2/floating_action_button.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/components2/scaffold.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/theme2/view_configuration.dart View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Hixie
lgtm
5 years, 6 months ago (2015-06-10 18:25:36 UTC) #1
eseidel
5 years, 6 months ago (2015-06-10 18:28:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6f750c7bb5a9c80fea1d02d0bce1abdcd9a4e82e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698