Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: sky/sdk/lib/framework/theme2/view_configuration.dart

Issue 1169813009: Add TODOs about components needing to adjust to screen size changes. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/lib/framework/components2/scaffold.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/framework/theme2/view_configuration.dart
diff --git a/sky/sdk/lib/framework/theme2/view_configuration.dart b/sky/sdk/lib/framework/theme2/view_configuration.dart
index e760f495cf5e7d711db7b2275fb1559865e13b2c..b31a5383869721c5b700e42b9a5add3d1e9d5911 100644
--- a/sky/sdk/lib/framework/theme2/view_configuration.dart
+++ b/sky/sdk/lib/framework/theme2/view_configuration.dart
@@ -8,7 +8,14 @@
const double kNotificationAreaHeight = 25.0;
// TODO(ianh): Figure out actual specced height for status bar
const double kStatusBarHeight = 50.0;
+
+// TODO(eseidel) Toolbar needs to change size based on orientation:
+// http://www.google.com/design/spec/layout/structure.html#structure-app-bar
+// Mobile Landscape: 48dp
+// Mobile Portrait: 56dp
+// Tablet/Desktop: 64dp
const double kToolBarHeight = 56.0;
+
const double kMaterialDrawerHeight = 140.0;
const double kScrollbarSize = 10.0;
const double kScrollbarFadeDuration = 250.0;
« no previous file with comments | « sky/sdk/lib/framework/components2/scaffold.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698