Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4056)

Unified Diff: sky/sdk/lib/framework/components2/scaffold.dart

Issue 1169813009: Add TODOs about components needing to adjust to screen size changes. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/sdk/lib/framework/components2/scaffold.dart
diff --git a/sky/sdk/lib/framework/components2/scaffold.dart b/sky/sdk/lib/framework/components2/scaffold.dart
index 355987db610453716f2b27246504f60390d25a08..6f1cdb21eed48f5525eb4714f4f8be0904df0622 100644
--- a/sky/sdk/lib/framework/components2/scaffold.dart
+++ b/sky/sdk/lib/framework/components2/scaffold.dart
@@ -79,6 +79,8 @@ class RenderScaffold extends RenderBox {
assert(size.height < double.INFINITY);
}
+ // TODO(eseidel): These change based on device size!
+ // http://www.google.com/design/spec/layout/metrics-keylines.html#metrics-keylines-keylines-spacing
static const kButtonX = 16.0; // left from right edge of body
static const kButtonY = 16.0; // up from bottom edge of body
« no previous file with comments | « sky/sdk/lib/framework/components2/floating_action_button.dart ('k') | sky/sdk/lib/framework/theme2/view_configuration.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698