Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/chrome_extensions_browser_client.cc

Issue 1168383002: Implement sidebar support for extension action popups Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix assertion failure at extension_view_host.cc Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc ('k') | chrome/browser/extensions/extension_action.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/chrome_extensions_browser_client.cc
diff --git a/chrome/browser/extensions/chrome_extensions_browser_client.cc b/chrome/browser/extensions/chrome_extensions_browser_client.cc
index eace973060beecbed31332b2ddf0e871c86576f6..c719e1234bd04e9af59fc8c254f29213e652741b 100644
--- a/chrome/browser/extensions/chrome_extensions_browser_client.cc
+++ b/chrome/browser/extensions/chrome_extensions_browser_client.cc
@@ -346,6 +346,7 @@ void ChromeExtensionsBrowserClient::AttachExtensionTaskManagerTag(
case VIEW_TYPE_EXTENSION_BACKGROUND_PAGE:
case VIEW_TYPE_EXTENSION_DIALOG:
case VIEW_TYPE_EXTENSION_POPUP:
+ case VIEW_TYPE_EXTENSION_SIDEBAR:
case VIEW_TYPE_LAUNCHER_PAGE:
case VIEW_TYPE_VIRTUAL_KEYBOARD:
// These are the only types that are tracked by the ExtensionTag.
« no previous file with comments | « chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc ('k') | chrome/browser/extensions/extension_action.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698