Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3245)

Unified Diff: chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc

Issue 1168383002: Implement sidebar support for extension action popups Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix assertion failure at extension_view_host.cc Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/chrome_extensions_browser_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc
diff --git a/chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc b/chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc
index 98f21933b505f650ca826afce5fb1dec91b9e7f5..6f10b1d942a3c6991b0a00b1e24fd369e43476ef 100644
--- a/chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc
+++ b/chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc
@@ -59,6 +59,9 @@ InspectableViewsFinder::View InspectableViewsFinder::ConstructView(
case VIEW_TYPE_EXTENSION_POPUP:
view->type = api::developer_private::VIEW_TYPE_EXTENSION_POPUP;
break;
+ case VIEW_TYPE_EXTENSION_SIDEBAR:
+ view->type = api::developer_private::VIEW_TYPE_EXTENSION_SIDEBAR;
+ break;
case VIEW_TYPE_LAUNCHER_PAGE:
view->type = api::developer_private::VIEW_TYPE_LAUNCHER_PAGE;
break;
@@ -135,7 +138,8 @@ void InspectableViewsFinder::GetViewsForExtensionProcess(
content::WebContents::FromRenderFrameHost(host);
ViewType host_type = GetViewType(web_contents);
if (host_type == VIEW_TYPE_EXTENSION_POPUP ||
- host_type == VIEW_TYPE_EXTENSION_DIALOG) {
+ host_type == VIEW_TYPE_EXTENSION_DIALOG ||
+ host_type == VIEW_TYPE_EXTENSION_SIDEBAR) {
continue;
}
« no previous file with comments | « no previous file | chrome/browser/extensions/chrome_extensions_browser_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698