Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Side by Side Diff: chrome/browser/extensions/chrome_extensions_browser_client.cc

Issue 1168383002: Implement sidebar support for extension action popups Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix assertion failure at extension_view_host.cc Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/chrome_extensions_browser_client.h" 5 #include "chrome/browser/extensions/chrome_extensions_browser_client.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/version.h" 8 #include "base/version.h"
9 #include "chrome/browser/app_mode/app_mode_utils.h" 9 #include "chrome/browser/app_mode/app_mode_utils.h"
10 #include "chrome/browser/browser_process.h" 10 #include "chrome/browser/browser_process.h"
(...skipping 328 matching lines...) Expand 10 before | Expand all | Expand 10 after
339 } 339 }
340 340
341 void ChromeExtensionsBrowserClient::AttachExtensionTaskManagerTag( 341 void ChromeExtensionsBrowserClient::AttachExtensionTaskManagerTag(
342 content::WebContents* web_contents, 342 content::WebContents* web_contents,
343 ViewType view_type) { 343 ViewType view_type) {
344 switch (view_type) { 344 switch (view_type) {
345 case VIEW_TYPE_APP_WINDOW: 345 case VIEW_TYPE_APP_WINDOW:
346 case VIEW_TYPE_EXTENSION_BACKGROUND_PAGE: 346 case VIEW_TYPE_EXTENSION_BACKGROUND_PAGE:
347 case VIEW_TYPE_EXTENSION_DIALOG: 347 case VIEW_TYPE_EXTENSION_DIALOG:
348 case VIEW_TYPE_EXTENSION_POPUP: 348 case VIEW_TYPE_EXTENSION_POPUP:
349 case VIEW_TYPE_EXTENSION_SIDEBAR:
349 case VIEW_TYPE_LAUNCHER_PAGE: 350 case VIEW_TYPE_LAUNCHER_PAGE:
350 case VIEW_TYPE_VIRTUAL_KEYBOARD: 351 case VIEW_TYPE_VIRTUAL_KEYBOARD:
351 // These are the only types that are tracked by the ExtensionTag. 352 // These are the only types that are tracked by the ExtensionTag.
352 task_management::WebContentsTags::CreateForExtension(web_contents, 353 task_management::WebContentsTags::CreateForExtension(web_contents,
353 view_type); 354 view_type);
354 return; 355 return;
355 356
356 case VIEW_TYPE_BACKGROUND_CONTENTS: 357 case VIEW_TYPE_BACKGROUND_CONTENTS:
357 case VIEW_TYPE_PANEL: 358 case VIEW_TYPE_PANEL:
358 case VIEW_TYPE_TAB_CONTENTS: 359 case VIEW_TYPE_TAB_CONTENTS:
359 // Those types are tracked by other tags: 360 // Those types are tracked by other tags:
360 // BACKGROUND_CONTENTS --> task_management::BackgroundContentsTag. 361 // BACKGROUND_CONTENTS --> task_management::BackgroundContentsTag.
361 // PANEL --> task_management::PanelTag. 362 // PANEL --> task_management::PanelTag.
362 // TAB_CONTENTS --> task_management::TabContentsTag. 363 // TAB_CONTENTS --> task_management::TabContentsTag.
363 // These tags are created and attached to the web_contents in other 364 // These tags are created and attached to the web_contents in other
364 // locations, and they must be ignored here. 365 // locations, and they must be ignored here.
365 return; 366 return;
366 367
367 case VIEW_TYPE_INVALID: 368 case VIEW_TYPE_INVALID:
368 NOTREACHED(); 369 NOTREACHED();
369 return; 370 return;
370 } 371 }
371 } 372 }
372 373
373 } // namespace extensions 374 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698