Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Unified Diff: chrome/browser/extensions/extension_action.h

Issue 1168383002: Implement sidebar support for extension action popups Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix assertion failure at extension_view_host.cc Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_action.h
diff --git a/chrome/browser/extensions/extension_action.h b/chrome/browser/extensions/extension_action.h
index 9e73dbc9e0a2564c82742906a0d3c48a0355aff8..ef85c5490cd6780be14858261208ceb512e5919f 100644
--- a/chrome/browser/extensions/extension_action.h
+++ b/chrome/browser/extensions/extension_action.h
@@ -70,6 +70,12 @@ class ExtensionAction {
std::string id() const { return id_; }
void set_id(const std::string& id) { id_ = id; }
+ // Should open Popup in sidebar?
+ bool open_in_sidebar() { return open_in_sidebar_; }
+ void set_open_in_sidebar(bool open_in_sidebar) {
+ open_in_sidebar_ = open_in_sidebar;
+ }
+
// Set the url which the popup will load when the user clicks this action's
// icon. Setting an empty URL will disable the popup for a given tab.
void SetPopupUrl(int tab_id, const GURL& url);
@@ -291,6 +297,9 @@ class ExtensionAction {
// needed for compat with an older version of the page actions API.
std::string id_;
+ // Popup should be open sidebar
+ bool open_in_sidebar_;
+
DISALLOW_COPY_AND_ASSIGN(ExtensionAction);
};
« no previous file with comments | « chrome/browser/extensions/chrome_extensions_browser_client.cc ('k') | chrome/browser/extensions/extension_action.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698